Skip to content

GH-48419: [Python] Fix test_parquet_file_too_small to catch only ArrowInvalid#48420

Merged
raulcd merged 1 commit intoapache:mainfrom
HyukjinKwon:GH-48419
Dec 10, 2025
Merged

GH-48419: [Python] Fix test_parquet_file_too_small to catch only ArrowInvalid#48420
raulcd merged 1 commit intoapache:mainfrom
HyukjinKwon:GH-48419

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Dec 9, 2025

Rationale for this change

The test does not throw OSError anymore.

What changes are included in this PR?

This PR changes test_parquet_file_too_small test to only catch ArrowInvalid.

Are these changes tested?

Yes, manually tested via

pytest pyarrow/tests/parquet/test_basic.py::test_parquet_file_too_small

Are there any user-facing changes?

No, test-only.

@github-actions
Copy link

github-actions bot commented Dec 9, 2025

⚠️ GitHub issue #48419 has been automatically assigned in GitHub to PR creator.

@raulcd
Copy link
Member

raulcd commented Dec 10, 2025

@github-actions crossbow submit -g python

Copy link
Member

@raulcd raulcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I am just running extended tests for CI coverage just in case. Will merge once CI is successful

@github-actions github-actions bot added awaiting merge Awaiting merge and removed awaiting review Awaiting review labels Dec 10, 2025
@github-actions
Copy link

Revision: 9950dc5

Submitted crossbow builds: ursacomputing/crossbow @ actions-ebe47310ef

Task Status
example-python-minimal-build-fedora-conda GitHub Actions
example-python-minimal-build-ubuntu-venv GitHub Actions
test-conda-python-3.10 GitHub Actions
test-conda-python-3.10-hdfs-2.9.2 GitHub Actions
test-conda-python-3.10-hdfs-3.2.1 GitHub Actions
test-conda-python-3.10-pandas-1.3.4-numpy-1.21.2 GitHub Actions
test-conda-python-3.11 GitHub Actions
test-conda-python-3.11-dask-latest GitHub Actions
test-conda-python-3.11-dask-upstream_devel GitHub Actions
test-conda-python-3.11-hypothesis GitHub Actions
test-conda-python-3.11-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.11-spark-master GitHub Actions
test-conda-python-3.12 GitHub Actions
test-conda-python-3.12-cpython-debug GitHub Actions
test-conda-python-3.12-pandas-latest-numpy-1.26 GitHub Actions
test-conda-python-3.12-pandas-latest-numpy-latest GitHub Actions
test-conda-python-3.13 GitHub Actions
test-conda-python-3.13-pandas-nightly-numpy-nightly GitHub Actions
test-conda-python-3.13-pandas-upstream_devel-numpy-nightly GitHub Actions
test-conda-python-3.14 GitHub Actions
test-conda-python-emscripten GitHub Actions
test-cuda-python-ubuntu-22.04-cuda-11.7.1 GitHub Actions
test-cuda-python-ubuntu-24.04-cuda-13.0.2 GitHub Actions
test-debian-12-python-3-amd64 GitHub Actions
test-debian-12-python-3-i386 GitHub Actions
test-fedora-42-python-3 GitHub Actions
test-ubuntu-22.04-python-3 GitHub Actions
test-ubuntu-22.04-python-313-freethreading GitHub Actions
test-ubuntu-24.04-python-3 GitHub Actions

@raulcd
Copy link
Member

raulcd commented Dec 10, 2025

CI failures are unrelated.

@raulcd raulcd merged commit 912eec1 into apache:main Dec 10, 2025
14 checks passed
@raulcd raulcd removed the awaiting merge Awaiting merge label Dec 10, 2025
@HyukjinKwon
Copy link
Member Author

Thank you @raulcd !!!

@conbench-apache-arrow
Copy link

After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 912eec1.

There were no benchmark performance regressions. 🎉

The full Conbench report has more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants