Skip to content

GH-48799: [C++] Improve SharedExclusiveChecker error messages #48800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pitrou merged 1 commit into from
Jan 12, 2026
+6 −5
Merged

GH-48799: [C++] Improve SharedExclusiveChecker error messages #48800

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions cpp/src/arrow/io/interfaces.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,10 +338,9 @@ SharedExclusiveChecker::SharedExclusiveChecker() : impl_(new Impl) {}

void SharedExclusiveChecker::LockShared() {
std::lock_guard<std::mutex> lock(impl_->mutex);
// XXX The error message doesn't really describe the actual situation
// (e.g. ReadAt() called while Read() call in progress)
ARROW_CHECK_EQ(impl_->n_exclusive, 0)
<< "Attempted to take shared lock while locked exclusive";
<< "Cannot perform position-independent I/O (ReadAt/GetSize) while an "
"exclusive operation (Read/Seek/Tell/Peek/Close/Abort) is in progress";
++impl_->n_shared;
}

Expand All @@ -354,9 +353,11 @@ void SharedExclusiveChecker::UnlockShared() {
void SharedExclusiveChecker::LockExclusive() {
std::lock_guard<std::mutex> lock(impl_->mutex);
ARROW_CHECK_EQ(impl_->n_shared, 0)
<< "Attempted to take exclusive lock while locked shared";
<< "Cannot perform exclusive I/O operation (Read/Seek/Tell/Peek/Close/Abort) while "
"position-independent operations (ReadAt/GetSize) are in progress";
ARROW_CHECK_EQ(impl_->n_exclusive, 0)
<< "Attempted to take exclusive lock while already locked exclusive";
<< "Cannot perform exclusive I/O operation (Read/Seek/Tell/Peek/Close/Abort) while "
"another exclusive operation is already in progress";
++impl_->n_exclusive;
}

Expand Down
Loading