GH-48885: [C++] Add missing curl dependency of Arrow::arrow_static CMake target#48891
Merged
kou merged 1 commit intoapache:mainfrom Jan 23, 2026
Merged
GH-48885: [C++] Add missing curl dependency of Arrow::arrow_static CMake target#48891kou merged 1 commit intoapache:mainfrom
Arrow::arrow_static CMake target#48891kou merged 1 commit intoapache:mainfrom
Conversation
|
|
github-actions
bot
added
Component: C++
awaiting committer review
github-actions
bot
added
awaiting changes
github-actions
bot
added
awaiting change review
kou
force-pushed
the
cpp-curl
branch
5 times, most recently
from
6f73a88 to
b2de466
Compare
…atic` CMake target
Member
Author
|
Rebased. This is ready. CI failures are fixed. |
github-actions
bot
added
awaiting merge
Member
Author
|
Correct. We can detect similar problems by new checks in |
|
After merging your PR, Conbench analyzed the 3 benchmarking runs that have been run so far on merge-commit 9489a66. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 31 possible false positives for unstable benchmarks that are known to sometimes produce them. |
raulcd
pushed a commit
that referenced
this pull request
Feb 3, 2026
…CMake target (#48891) ### Rationale for this change We changed `macro(build_google_cloud_cpp_storage)` to `function(...)` in GH-48333 . So `find_curl()` doesn't change `ARROW_SYSTEM_DEPENDENCIES` in parent scope. (`function()` creates a new scope.) ### What changes are included in this PR? Move `find_curl()` to the top-level from in `function(build_google_cloud_cpp_storage)`. ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: #48885 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
We changed
macro(build_google_cloud_cpp_storage)tofunction(...)in GH-48333 . Sofind_curl()doesn't changeARROW_SYSTEM_DEPENDENCIESin parent scope. (function()creates a new scope.)What changes are included in this PR?
Move
find_curl()to the top-level from infunction(build_google_cloud_cpp_storage).Are these changes tested?
Yes.
Are there any user-facing changes?
Yes.