Fix bug when execute DataframeTransform a dictionary of Pcoll

[DKER2]

addresses #30445

Fix duplicate transform function name by giving custom label (key in dicts of dataframes) instead of using default label as in this line it will take the first two characters of the variable name to construct the label, so if two variables start with the same two characters(e.g pcol1, pcol2), there will a conflict

---

Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

• Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
• Update CHANGES.md with noteworthy changes.
• If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

[gemini-code-assist]

Summary of Changes

Hello @DKER2, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a bug in DataframeTransform within Apache Beam's Python SDK, specifically when it processes a dictionary of PCollections. The fix involves correctly passing an additional argument during the conversion of PCollections to DataFrames, ensuring proper handling of multiple inputs. A new test case has been added to validate this functionality. Additionally, a minor update to a warning message format in core.py is included.

Highlights

• DataframeTransform Bug Fix: Corrected an issue in sdks/python/apache_beam/dataframe/transforms.py where DataframeTransform failed to properly process a dictionary of PCollections. The fix involves passing str(k) as a third argument to convert.to_dataframe when iterating through dictionary items.
• New Test Case for Multiple DataFrames: Added test_multiple_dataframe_transforms in sdks/python/apache_beam/dataframe/transforms_test.py to ensure DataframeTransform correctly handles scenarios with multiple input PCollections provided as a dictionary.
• Warning Message Formatting Update: Updated a warning message in sdks/python/apache_beam/transforms/core.py to use an f-string for improved readability and modern Python syntax.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[github-actions]

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 36.10%. Comparing base (3659832) to head (06d0bda).

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #35893      +/-   ##
============================================
- Coverage     36.11%   36.10%   -0.01%     
  Complexity     1618     1618              
============================================
  Files          1057     1057              
  Lines        164393   164415      +22     
  Branches       1165     1165              
============================================
+ Hits          59363    59369       +6     
- Misses       102878   102894      +16     
  Partials       2152     2152              

Flag	Coverage Δ
python	40.52% <ø> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Assigning reviewers:

R: @damccorm for label python.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

[DKER2]

Thanks. This will potentially break update compatibility for streaming jobs (which rely on step name to map new transforms to old), but I think that it is worth it to allow this kind of usage.

Could you please add a note to CHANGES.md calling out this bug fix?

Updated CHANGES.md @damccorm. Thank you

[DKER2]

investigating failed test case

[github-actions]

Reminder, please take a look at this pr: @damccorm

[damccorm]

I'm not sure, but I think the test failures may just be flaky tests

[damccorm]

Sorry, missed this PR - would you mind specifically calling out that this could break update compatibility

Suggested change

	* (Python) Fixed transform naming conflict when executing DataTransform on a dictionary of PColls ([#30445][https://github.com/apache/beam/issues/30445])
	* (Python) Fixed transform naming conflict when executing DataTransform on a dictionary of PColls ([#30445][https://github.com/apache/beam/issues/30445]). This may break update compatibility if you don't provide a `--transform_name_mapping`.

Also, could you move it to 2.69.0's breaking changes section?

[DKER2]

Thanks @damccorm , done. I dont think build error is related to this PR

[github-actions]

Assigning new set of reviewers because Pr has gone too long without review. If you would like to opt out of this review, comment assign to next reviewer:

R: @jrmccluskey for label python.

Available commands:

• stop reviewer notifications - opt out of the automated review tooling
• remind me after tests pass - tag the comment author after tests pass
• waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

[damccorm]

waiting on author

[damccorm]

Thanks! LGTM