-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Fix bug when execute DataframeTransform a dictionary of Pcoll #35893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 24 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
f1d9e93
Log Warning if process function return None
3cdb629
Fix get function without inner
9170808
check the first def_line also
9370ed2
rename variable
6219664
add strip function
5a3c1a6
reformat function
3bfc43d
refactor code
278d186
fix bug in get function body
f07d2cd
Merge branch 'master' into master
DKER2 e819366
retrigger test
25d5431
retrigger test
52f59ff
fix: unexpected error when transform two pcoll
DKER2 69ed085
revert redundant
DKER2 e6b636c
Merge branch 'master' into fx-30445
DKER2 d194838
fix test
DKER2 4acae69
reformat file
DKER2 12c4973
simply change test case
DKER2 d5f052c
change test case
DKER2 9193339
change test case
DKER2 f1e5fd7
retrigger test
DKER2 faa4fd0
Merge branch 'master' into fx-30445
DKER2 f04d6c7
Merge branch 'master' into fx-30445
DKER2 d3ceae7
update change.md
DKER2 a966505
update change.md
DKER2 4338599
Merge branch 'master' into fx-30445
DKER2 06d0bda
update change.md
DKER2 5364c52
update change.md
DKER2 4539d04
update format of change.md
DKER2 422b3f7
update format of change.md
DKER2 e18b6be
update format of change.md
DKER2 c36572e
update format of change.md
DKER2 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, missed this PR - would you mind specifically calling out that this could break update compatibility
Also, could you move it to 2.69.0's breaking changes section?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @damccorm , done. I dont think build error is related to this PR