Skip to content

Fix unable download twitter dependencies#1966

Merged
sijie merged 2 commits intoapache:masterfrom
zymap:master
Feb 27, 2019
Merged

Fix unable download twitter dependencies#1966
sijie merged 2 commits intoapache:masterfrom
zymap:master

Conversation

@zymap
Copy link
Member

@zymap zymap commented Feb 26, 2019


Fixes #1962

Motivation

There are some twitter dependencies can't download from repo

Modifications

  • remove some using in StatsLoggerBenchmark.java
  • update some config in pom.xml

Descriptions of the changes in this PR:

You can add -Dtwitter to choose add twitter dependencies.

Motivation

(Explain: why you're making that change, what is the problem you're trying to solve)

Changes

(Describe: what changes you have made)

Master Issue: #1962


In order to uphold a high standard for quality for code contributions, Apache BookKeeper runs various precommit
checks for pull requests. A pull request can only be merged when it passes precommit checks. However running all
the precommit checks can take a long time, some trivial changes don't need to run all the precommit checks. You
can check following list to skip the tests that don't need to run for your pull request. Leave them unchecked if
you are not sure, committers will help you:

  • [skip bookkeeper-server bookie tests]: skip testing org.apache.bookkeeper.bookie in bookkeeper-server module.
  • [skip bookkeeper-server client tests]: skip testing org.apache.bookkeeper.client in bookkeeper-server module.
  • [skip bookkeeper-server replication tests]: skip testing org.apache.bookkeeper.replication in bookkeeper-server module.
  • [skip bookkeeper-server tls tests]: skip testing org.apache.bookkeeper.tls in bookkeeper-server module.
  • [skip bookkeeper-server remaining tests]: skip testing all other tests in bookkeeper-server module.
  • [skip integration tests]: skip docker based integration tests. if you make java code changes, you shouldn't skip integration tests.
  • [skip build java8]: skip build on java8. ONLY skip this when ONLY changing files under documentation under site.
  • [skip build java11]: skip build on java11. ONLY skip this when ONLY changing files under documentation under site.


Be sure to do all of the following to help us incorporate your contribution
quickly and easily:

If this PR is a BookKeeper Proposal (BP):

  • Make sure the PR title is formatted like:
    <BP-#>: Description of bookkeeper proposal
    e.g. BP-1: 64 bits ledger is support
  • Attach the master issue link in the description of this PR.
  • Attach the google doc link if the BP is written in Google Doc.

Otherwise:

  • Make sure the PR title is formatted like:
    <Issue #>: Description of pull request
    e.g. Issue 123: Description ...
  • Make sure tests pass via mvn clean apache-rat:check install spotbugs:check.
  • Replace <Issue #> in the title with the actual Issue number.

---

Fixes apache#1962

*Motivation*

There are some twitter dependencies can't download from repo

*Modifications*

- remove some using in StatsLoggerBenchmark.java
- update some config in pom.xml
Co-Authored-By: zymap <zhangyong1025.zy@gmail.com>
@jiazhai
Copy link
Member

jiazhai commented Feb 27, 2019

run bookkeeper-server bookie tests

org.apache.bookkeeper.bookie.BookieStickyReadsTest.stickyReadsWithFailures(org.apache.bookkeeper.bookie.BookieStickyReadsTest)
2019-02-26\T\11:22:16.166 [ERROR]   Run 1: BookieStickyReadsTest.stickyReadsWithFailures:137 » TestTimedOut test timed ou...
2019-02-26\T\11:22:16.166 [ERROR]   Run 2: BookieStickyReadsTest.stickyReadsWithFailures:171 expected:<0> but was:<1>
2019-02-26\T\11:22:16.166 [ERROR]   Run 3: BookieStickyReadsTest.stickyReadsWithFailures:171 expected:<0> but was:<1>
2019-02-26\T\11:22:16.166 [INFO] 
2019-02-26\T\11:22:16.166 [ERROR] org.apache.bookkeeper.bookie.BookieStickyReadsTest.stickyReadsWithNoFailures(org.apache.bookkeeper.bookie.BookieStickyReadsTest)
2019-02-26\T\11:22:16.166 [ERROR]   Run 1: BookieStickyReadsTest.stickyReadsWithNoFailures:90->writeAndReadEntries:208 » TestTimedOut
2019-02-26\T\11:22:16.166 [ERROR]   Run 2: BookieStickyReadsTest.stickyReadsWithNoFailures:90->writeAndReadEntries:208 » TestTimedOut
2019-02-26\T\11:22:16.167 [ERROR]   Run 3: BookieStickyReadsTest.stickyReadsWithNoFailures:90->writeAndReadEntries:208 » TestTimedOut
2019-02-26\T\11:22:16.167 [INFO] 
2019-02-26\T\11:22:16.167 [INFO] 

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sijie @ivankelly I am fine with this change.
How about LICENSE/NOTICE files?

The 'all' package will be smaller, I am not sure about the right approach to take

@sijie
Copy link
Member

sijie commented Feb 27, 2019

@eolivelli

How about LICENSE/NOTICE files?

what LICENSE files? we are not changing any distributions. CI verified licenses and notices and they all passed.

@sijie sijie added this to the 4.10.0 milestone Feb 27, 2019
@sijie sijie merged commit b689d83 into apache:master Feb 27, 2019
cdbartholomew pushed a commit to kafkaesque-io/bookkeeper that referenced this pull request Feb 4, 2020
---

Fixes apache#1962

*Motivation*

There are some twitter dependencies can't download from repo

*Modifications*

- remove some using in StatsLoggerBenchmark.java
- update some config in pom.xml

Descriptions of the changes in this PR:

You can add -Dtwitter to choose add twitter dependencies.

### Motivation

(Explain: why you're making that change, what is the problem you're trying to solve)

### Changes

(Describe: what changes you have made)

Master Issue: apache#1962




Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <zhaijia@apache.org>, Sijie Guo <sijie@apache.org>

This closes apache#1966 from zymap/master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants