Fix unable download twitter dependencies#1966
Merged
sijie merged 2 commits intoapache:masterfrom Feb 27, 2019
Merged
Conversation
--- Fixes apache#1962 *Motivation* There are some twitter dependencies can't download from repo *Modifications* - remove some using in StatsLoggerBenchmark.java - update some config in pom.xml
sijie
requested changes
Feb 26, 2019
Co-Authored-By: zymap <zhangyong1025.zy@gmail.com>
Member
|
run bookkeeper-server bookie tests |
jiazhai
approved these changes
Feb 27, 2019
eolivelli
approved these changes
Feb 27, 2019
Contributor
eolivelli
left a comment
There was a problem hiding this comment.
@sijie @ivankelly I am fine with this change.
How about LICENSE/NOTICE files?
The 'all' package will be smaller, I am not sure about the right approach to take
Member
what LICENSE files? we are not changing any distributions. CI verified licenses and notices and they all passed. |
sijie
approved these changes
Feb 27, 2019
cdbartholomew
pushed a commit
to kafkaesque-io/bookkeeper
that referenced
this pull request
Feb 4, 2020
--- Fixes apache#1962 *Motivation* There are some twitter dependencies can't download from repo *Modifications* - remove some using in StatsLoggerBenchmark.java - update some config in pom.xml Descriptions of the changes in this PR: You can add -Dtwitter to choose add twitter dependencies. ### Motivation (Explain: why you're making that change, what is the problem you're trying to solve) ### Changes (Describe: what changes you have made) Master Issue: apache#1962 Reviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <zhaijia@apache.org>, Sijie Guo <sijie@apache.org> This closes apache#1966 from zymap/master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1962
Motivation
There are some twitter dependencies can't download from repo
Modifications
Descriptions of the changes in this PR:
You can add -Dtwitter to choose add twitter dependencies.
Motivation
(Explain: why you're making that change, what is the problem you're trying to solve)
Changes
(Describe: what changes you have made)
Master Issue: #1962