Skip to content

Fix unable download twitter dependencies #1966

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sijie merged 2 commits into from
Feb 27, 2019
Merged

Fix unable download twitter dependencies #1966

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c92eb4c
Fix unable download twitter dependencies
zymap Feb 26, 2019
acfab01
Apply suggestions
sijie Feb 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 0 additions & 20 deletions bookkeeper-server/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -241,26 +241,6 @@
</plugins>
</build>
<profiles>
<profile>
<id>twitter-science-provider</id>
<dependencies>
<dependency>
<groupId>org.apache.bookkeeper.stats</groupId>
<artifactId>twitter-science-provider</artifactId>
<version>${project.parent.version}</version>
</dependency>
</dependencies>
</profile>
<profile>
<id>codahale-metrics-provider</id>
<dependencies>
<dependency>
<groupId>org.apache.bookkeeper.stats</groupId>
<artifactId>codahale-metrics-provider</artifactId>
<version>${project.parent.version}</version>
</dependency>
</dependencies>
</profile>
<profile>
<id>twitter-http-server</id>
<dependencies>
Expand Down
21 changes: 18 additions & 3 deletions bookkeeper-stats-providers/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,25 @@
<packaging>pom</packaging>
<name>Apache BookKeeper :: Stats Providers</name>
<modules>
<module>twitter-finagle-provider</module>
<module>twitter-science-provider</module>
<module>twitter-ostrich-provider</module>
<module>codahale-metrics-provider</module>
<module>prometheus-metrics-provider</module>
</modules>

<profiles>
<profile>
<id>twitter</id>
<activation>
<property>
<name>twitter</name>
</property>
</activation>
<modules>
<!-- enable building table service -->
<module>twitter-finagle-provider</module>
<module>twitter-science-provider</module>
<module>twitter-ostrich-provider</module>
</modules>
</profile>
</profiles>

</project>
10 changes: 0 additions & 10 deletions microbenchmarks/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,16 +63,6 @@
<artifactId>codahale-metrics-provider</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.apache.bookkeeper.stats</groupId>
<artifactId>twitter-science-provider</artifactId>
<version>${project.version}</version>
</dependency>
<dependency>
<groupId>org.apache.bookkeeper.stats</groupId>
<artifactId>twitter-ostrich-provider</artifactId>
<version>${project.version}</version>
</dependency>
</dependencies>
<build>
<plugins>
Expand Down
4 changes: 0 additions & 4 deletions microbenchmarks/src/main/java/org/apache/bookkeeper/stats/StatsLoggerBenchmark.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,6 @@
import org.apache.bookkeeper.stats.codahale.CodahaleMetricsProvider;
import org.apache.bookkeeper.stats.codahale.FastCodahaleMetricsProvider;
import org.apache.bookkeeper.stats.prometheus.PrometheusMetricsProvider;
import org.apache.bookkeeper.stats.twitter.ostrich.OstrichProvider;
import org.apache.bookkeeper.stats.twitter.science.TwitterStatsProvider;
import org.openjdk.jmh.annotations.Benchmark;
import org.openjdk.jmh.annotations.Fork;
import org.openjdk.jmh.annotations.Level;
Expand Down Expand Up @@ -60,8 +58,6 @@ public class StatsLoggerBenchmark {
providers.put("Prometheus", PrometheusMetricsProvider::new);
providers.put("Codahale", CodahaleMetricsProvider::new);
providers.put("FastCodahale", FastCodahaleMetricsProvider::new);
providers.put("Twitter", TwitterStatsProvider::new);
providers.put("Ostrich", OstrichProvider::new);
}

@State(Scope.Benchmark)
Expand Down