Check rocksdb closed before operating #4243
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnonHxy
force-pushed
the
operate_db_after_close
branch
from
8c6e5ff to
f362987
Compare
Member
Member
|
@AnonHxy The javadoc of org.rocksdb.RocksDB#close says: Would it make sense to also take this into account by adding |
merlimat
reviewed
Mar 5, 2025
|
|
||
| @Override | ||
| public void put(byte[] key, byte[] value) throws IOException { | ||
| readLock.lock(); |
Contributor
There was a problem hiding this comment.
Acquiring the read lock for each put/get operation might be quite expensive, since the lock has to maintain the state of threads and the order they try to acquire the lock.
We could use a different approach, like a reference counter on the entire object. When everyone is done using it, then rocksdb is really closed
Member
Member
There was a problem hiding this comment.
There's an alternative PR #4581 which simply handles close and count
zhaizhibo
pushed a commit
to zhaizhibo/bookkeeper
that referenced
this pull request
Apr 16, 2025
…t() (possibly triggered by Prometheus) after RocksDB has been closed(apache#4243)
zhaizhibo
pushed a commit
to zhaizhibo/bookkeeper
that referenced
this pull request
Apr 16, 2025
…t() (possibly triggered by Prometheus) after RocksDB has been closed(apache#4243)
lhotari
pushed a commit
that referenced
this pull request
Apr 17, 2025
…t after rocksdb has been closed (#4581) * Fix the coredump that occurs when calling KeyValueStorageRocksDB.count() (possibly triggered by Prometheus) after RocksDB has been closed(#4243) * fix race when count op in process and db gets closed. --------- Co-authored-by: zhaizhibo <[email protected]>
lhotari
pushed a commit
that referenced
this pull request
Apr 17, 2025
…t after rocksdb has been closed (#4581) * Fix the coredump that occurs when calling KeyValueStorageRocksDB.count() (possibly triggered by Prometheus) after RocksDB has been closed(#4243) * fix race when count op in process and db gets closed. --------- Co-authored-by: zhaizhibo <[email protected]> (cherry picked from commit 2831ed3)
lhotari
pushed a commit
that referenced
this pull request
Apr 17, 2025
…t after rocksdb has been closed (#4581) * Fix the coredump that occurs when calling KeyValueStorageRocksDB.count() (possibly triggered by Prometheus) after RocksDB has been closed(#4243) * fix race when count op in process and db gets closed. --------- Co-authored-by: zhaizhibo <[email protected]> (cherry picked from commit 2831ed3)
lhotari
pushed a commit
that referenced
this pull request
Apr 17, 2025
…t after rocksdb has been closed (#4581) * Fix the coredump that occurs when calling KeyValueStorageRocksDB.count() (possibly triggered by Prometheus) after RocksDB has been closed(#4243) * fix race when count op in process and db gets closed. --------- Co-authored-by: zhaizhibo <[email protected]> (cherry picked from commit 2831ed3)
Contributor
priyanshu-ctds
pushed a commit
to datastax/bookkeeper
that referenced
this pull request
Jul 11, 2025
…t after rocksdb has been closed (apache#4581) * Fix the coredump that occurs when calling KeyValueStorageRocksDB.count() (possibly triggered by Prometheus) after RocksDB has been closed(apache#4243) * fix race when count op in process and db gets closed. --------- Co-authored-by: zhaizhibo <[email protected]> (cherry picked from commit 2831ed3) (cherry picked from commit 9d067f4)
sandeep-ctds
pushed a commit
to datastax/bookkeeper
that referenced
this pull request
Jul 22, 2025
…t after rocksdb has been closed (apache#4581) * Fix the coredump that occurs when calling KeyValueStorageRocksDB.count() (possibly triggered by Prometheus) after RocksDB has been closed(apache#4243) * fix race when count op in process and db gets closed. --------- Co-authored-by: zhaizhibo <[email protected]> (cherry picked from commit 2831ed3) (cherry picked from commit 9d067f4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Motivation
Fix #4238
From the issue above we can see that the core dump could happen when operate Rocksdb after it has been closed. So we should check if closed before operating rocksdb.
Changes
Checking if closed before operation RocksDB.