Fix the coredump that occurs when calling KeyValueStorageRocksDB.count after rocksdb has been closed #4581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t() (possibly triggered by Prometheus) after RocksDB has been closed(apache#4243)
Member
|
There's already #4243 to handle this issue. |
Contributor
Author
Member
@zhaizhibo With this PR there could also be a race such as the count operation is in progress while the database gets closed. That would most likely result in a core dump as well. There's a need for a lock. |
lhotari
requested changes
Apr 16, 2025
Member
lhotari
left a comment
lhotari
left a comment
There was a problem hiding this comment.
In addition to the closed flag, there's a need to have an exclusive lock on close and count methods so that the database doesn't get closed while the count method is executing. One possible solution is a StampedLock since a re-entrant lock isn't needed. The count method could acquire a read lock and close would acquire a write lock.
Member
|
@zhaizhibo Please fix the checkstyle issues. |
Contributor
Author
|
@lhotari fixed. |
lhotari
requested review from
dlg99,
eolivelli,
hezhangjian,
merlimat and
zymap
hezhangjian
approved these changes
Apr 17, 2025
Member
|
+1 |
lhotari
pushed a commit
that referenced
this pull request
Apr 17, 2025
…t after rocksdb has been closed (#4581) * Fix the coredump that occurs when calling KeyValueStorageRocksDB.count() (possibly triggered by Prometheus) after RocksDB has been closed(#4243) * fix race when count op in process and db gets closed. --------- Co-authored-by: zhaizhibo <[email protected]> (cherry picked from commit 2831ed3)
lhotari
pushed a commit
that referenced
this pull request
Apr 17, 2025
…t after rocksdb has been closed (#4581) * Fix the coredump that occurs when calling KeyValueStorageRocksDB.count() (possibly triggered by Prometheus) after RocksDB has been closed(#4243) * fix race when count op in process and db gets closed. --------- Co-authored-by: zhaizhibo <[email protected]> (cherry picked from commit 2831ed3)
lhotari
pushed a commit
that referenced
this pull request
Apr 17, 2025
…t after rocksdb has been closed (#4581) * Fix the coredump that occurs when calling KeyValueStorageRocksDB.count() (possibly triggered by Prometheus) after RocksDB has been closed(#4243) * fix race when count op in process and db gets closed. --------- Co-authored-by: zhaizhibo <[email protected]> (cherry picked from commit 2831ed3)
priyanshu-ctds
pushed a commit
to datastax/bookkeeper
that referenced
this pull request
Jul 11, 2025
…t after rocksdb has been closed (apache#4581) * Fix the coredump that occurs when calling KeyValueStorageRocksDB.count() (possibly triggered by Prometheus) after RocksDB has been closed(apache#4243) * fix race when count op in process and db gets closed. --------- Co-authored-by: zhaizhibo <[email protected]> (cherry picked from commit 2831ed3) (cherry picked from commit 9d067f4)
sandeep-ctds
pushed a commit
to datastax/bookkeeper
that referenced
this pull request
Jul 22, 2025
…t after rocksdb has been closed (apache#4581) * Fix the coredump that occurs when calling KeyValueStorageRocksDB.count() (possibly triggered by Prometheus) after RocksDB has been closed(apache#4243) * fix race when count op in process and db gets closed. --------- Co-authored-by: zhaizhibo <[email protected]> (cherry picked from commit 2831ed3) (cherry picked from commit 9d067f4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Descriptions of the changes in this PR:
Motivation
Fix #4238
Changes
Add a boolean status check before KeyValueStorageRocksDB.count()