Skip to content

Let gpstop error message about environment variable readable #1318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tuhaihe merged 3 commits into from
Dec 23, 2025
Merged

Let gpstop error message about environment variable readable #1318

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1b82ef
Update gpstop
water32 Aug 20, 2025
ff59da5
Improve error message when COORDINATOR_DATA_DIRECTORY is unset
tuhaihe Dec 18, 2025
a4e3bff
Update the way import
tuhaihe Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions gpMgmt/bin/gpstart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -902,9 +902,7 @@ class GpStart:

if is_external_fts:
if options.fts_hosts is None:
coordinator_data_directory = os.getenv('COORDINATOR_DATA_DIRECTORY')
if coordinator_data_directory is None:
coordinator_data_directory = options.coordinatorDataDirectory
coordinator_data_directory = gp.get_coordinatordatadir()
options.fts_hosts = coordinator_data_directory + '/config' + '/fts_host'

return GpStart(options.specialMode, options.restricted,
Expand Down
4 changes: 1 addition & 3 deletions gpMgmt/bin/gpstop
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -959,9 +959,7 @@ class GpStop:

if is_external_fts:
if options.fts_hosts is None:
coordinator_data_directory = os.getenv('COORDINATOR_DATA_DIRECTORY')
if coordinator_data_directory is None:
coordinator_data_directory = options.coordinatorDataDirectory
coordinator_data_directory = gp.get_coordinatordatadir()

options.fts_hosts = coordinator_data_directory + '/config' + '/fts_host'

Expand Down
Loading