Skip to content

Conversation

@water32
Copy link
Contributor

@water32 water32 commented Aug 20, 2025

When the environment variables COORDINATOR_DATA_DIRECTORY are not set correctly, the error message is meaningless

Fixes #ISSUE_Number

What does this PR do?

Type of Change

  • Bug fix (non-breaking change)
  • New feature (non-breaking change)
  • Breaking change (fix or feature with breaking changes)
  • Documentation update

Breaking Changes

Test Plan

  • Unit tests added/updated
  • Integration tests added/updated
  • Passed make installcheck
  • Passed make -C src/test installcheck-cbdb-parallel

Impact

Performance:

User-facing changes:

Dependencies:

Checklist

Additional Context

CI Skip Instructions


Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @water32 welcome!🎊 Thanks for taking the effort to make our project better! 🙌 Keep making such awesome contributions!

@tuhaihe
Copy link
Member

tuhaihe commented Aug 20, 2025

Hi @water32 thanks for your contribution! Could you please update the commit title and message body following our commit convention .gitmessage for a better context? Thanks.

@water32 water32 changed the title Update gpstop Let gpstop error message about environment variable readable Aug 26, 2025
@tuhaihe
Copy link
Member

tuhaihe commented Dec 18, 2025

Hi @water32 welcome to rebase your commit. You can take the following commit message title and commit body as a reference:

Improve error message when COORDINATOR_DATA_DIRECTORY is unset

This commit updates gpstop and gpstart to use shared logic when
determining the coordinator data directory.

By relying on the common helper, users receive clearer and more
actionable error messages when COORDINATOR_DATA_DIRECTORY is unset
or invalid, making startup and shutdown failures easier to diagnose.

water32 and others added 3 commits December 23, 2025 10:33
When the environment variables COORDINATOR_DATA_DIRECTORY are not set correctly, the error message is meaningless
@tuhaihe tuhaihe merged commit 897c057 into apache:main Dec 23, 2025
59 of 62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants