pre-commit: add oxipng for lossless PNG compression #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs apache/cloudstack#11065
Made the
oxipnga manual hook since it takes a long time to run.So when running the standard pre-commit command
pre-commit run --all-filesthe manual hooks won't run and slow down development.You can always run a full repository clean up by running the manual hooks on your local machine with:
pre-commit run --all-files --hook-stage manualI have also added the "manual" hook run to the CI so we don't lose coverage.
We can see now how long the GitHub Actions run takes.
I also renamed the
pre-commit.ymlworkflow file