Skip to content

Conversation

@DaanHoogland
Copy link
Contributor

Description

This PR, ...

Fixes: #9805

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 15.13%. Comparing base (1ff68cf) to head (5c7935f).
Report is 32 commits behind head on 4.19.

Files with missing lines Patch % Lines
...ain/java/com/cloud/api/query/QueryManagerImpl.java 0.00% 6 Missing ⚠️
...pi/command/user/offering/ListDiskOfferingsCmd.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               4.19   #10228   +/-   ##
=========================================
  Coverage     15.13%   15.13%           
- Complexity    11275    11280    +5     
=========================================
  Files          5408     5408           
  Lines        474007   474015    +8     
  Branches      57822    57824    +2     
=========================================
+ Hits          71728    71744   +16     
+ Misses       394260   394249   -11     
- Partials       8019     8022    +3     
Flag Coverage Δ
uitests 4.30% <ø> (ø)
unittests 15.85% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHoogland
Copy link
Contributor Author

@blueorangutan package

@blueorangutan
Copy link

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12149

@Pearl1594
Copy link
Contributor

I think the title of the PR is misleading

@DaanHoogland DaanHoogland changed the title list network offerings with specific tags only list disk offerings with specific tags only Jan 21, 2025
@DaanHoogland DaanHoogland changed the title list disk offerings with specific tags only list disk offerings by tags Jan 21, 2025
@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12151

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12161

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12163

@DaanHoogland
Copy link
Contributor Author

issue #9805 abandonned

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect disk offering is listed when volume migration is initiated

4 participants