Improve listing of HA and non-HA hosts when ha.tag setting is defined and hosts have multiple tags along with ha tag

[sureshanaparti]

Description

This PR improves listing of HA and non-HA hosts when ha.tag setting is defined and hosts have multiple tags along with ha tag.

Fixes #10070

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• build/CI
• test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 42 lines in your changes missing coverage. Please review.

Project coverage is 15.13%. Comparing base (91f1ada) to head (cd2cfa1).
Report is 29 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
.../src/main/java/com/cloud/host/dao/HostDaoImpl.java	0.00%	40 Missing ⚠️
...in/java/com/cloud/server/ManagementServerImpl.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.19   #10240   +/-   ##
=========================================
  Coverage     15.13%   15.13%           
- Complexity    11279    11282    +3     
=========================================
  Files          5408     5408           
  Lines        474007   474025   +18     
  Branches      57822    57827    +5     
=========================================
+ Hits          71745    71752    +7     
- Misses       394241   394251   +10     
- Partials       8021     8022    +1     

Flag	Coverage Δ
uitests	4.30% <ø> (ø)
unittests	15.85% <0.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12170

[vishesh92]

clgtm

[Pearl1594]

code LGTM

[DaanHoogland]

tested with multiple combinations of tags and checked the hahost outputparameter in cmk.

[DaanHoogland]

@blueorangutan package

[blueorangutan]

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[DaanHoogland]

@blueorangutan test

[blueorangutan]

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12303

[blueorangutan]

[SF] Trillian Build Failed (tid-12275)

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12310

[blueorangutan]

[SF] Trillian test result (tid-12278)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 47953 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10240-t12278-kvm-ol8.zip
Smoke tests completed. 131 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_secure_vm_migration	Error	134.33	test_vm_life_cycle.py
test_01_secure_vm_migration	Error	134.34	test_vm_life_cycle.py
test_12_start_vm_multiple_volumes_allocated	Error	15.07	test_vm_life_cycle.py
test_05_vmschedule_test_e2e	Failure	362.29	test_vm_schedule.py

[weizhouapache]

@DaanHoogland
test results look ok
so this might not be the root cause of 4.19 health check test failures