migrate Vmware to KVM ui issues #10413

DaanHoogland · 2025-02-17T17:57:55Z

Description

This PR...

Fixes: #10412

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

in local UI pointing to a lab env

DaanHoogland · 2025-02-17T17:58:12Z

@blueorangutan ui

codecov · 2025-02-17T18:06:02Z

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 15.15%. Comparing base (212f2a3) to head (23cc58d).
Report is 3 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...in/java/com/cloud/hypervisor/vmware/mo/BaseMO.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19   #10413      +/-   ##
============================================
- Coverage     15.15%   15.15%   -0.01%     
+ Complexity    11318    11316       -2     
============================================
  Files          5413     5413              
  Lines        474670   474700      +30     
  Branches      57890    57893       +3     
============================================
- Hits          71953    71939      -14     
- Misses       394668   394716      +48     
+ Partials       8049     8045       -4

Flag	Coverage Δ
uitests	`4.29% <ø> (-0.01%)`	⬇️
unittests	`15.87% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

harikrishna-patnala · 2025-02-18T04:22:16Z

@blueorangutan ui

blueorangutan · 2025-02-18T04:23:03Z

@harikrishna-patnala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-02-18T04:40:17Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10413 (QA-JID-555)

harikrishna-patnala

code LGTM.

I see the method is returning boolean but not used. Probably its good to change the method name listZoneVmwareDcHosts -> loadZoneVmwareDcHosts

kiranchavala

@DaanHoogland

Before the fix, there are lot of notifications, when the vcenter password is entered

After fix, I have noticed that the message "No vmware hosts were in the selected Datacenter" when no details are given and also when details are provided

And on submitting List Vmware Instances , it list all the vm present in the datacenter

DaanHoogland · 2025-02-18T08:03:43Z

@kiranchavala, I made some changes to address your comments. Can you have another look?
@harikrishna-patnala, I renamed the method.

DaanHoogland · 2025-02-18T08:03:47Z

@blueorangutan ui

blueorangutan · 2025-02-18T08:05:04Z

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-02-18T08:21:39Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/10413 (QA-JID-556)

ui/src/views/tools/SelectVmwareVcenter.vue

This reverts commit f0e9393.

kiranchavala · 2025-02-18T10:58:00Z

@blueorangutan package

blueorangutan · 2025-02-18T11:00:04Z

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-02-18T12:01:11Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12500

blueorangutan · 2025-02-18T16:11:45Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12506

kiranchavala

LGTM, verified manually , no more error notifications are present.

kiranchavala

@DaanHoogland

Could you please change the text from

No EXSi hosts were found in the selected Datacenter. Are the credentials complete?

to

No EXSi hosts were found in the selected Datacenter. Are the entered credentials correct?

Also if incorrect credentials are entered can cloudstack thrown a error notification ?

DaanHoogland · 2025-02-19T09:20:02Z

@sureshanaparti , is this ok by you now?

sureshanaparti

clgtm

sureshanaparti · 2025-02-19T09:45:32Z

@DaanHoogland

Could you please change the text from

No EXSi hosts were found in the selected Datacenter. Are the credentials complete?

to

No EXSi hosts were found in the selected Datacenter. Are the entered credentials correct?

Also if incorrect credentials are entered can cloudstack thrown a error notification ?

@DaanHoogland @kiranchavala on entry key in password field with incorrect credentials, throws error notification ?

DaanHoogland · 2025-02-19T10:39:43Z

Also if incorrect credentials are entered can cloudstack thrown a error notification ?

@DaanHoogland @kiranchavala on entry key in password field with incorrect credentials, throws error notification ?

@sureshanaparti @kiranchavala , I experimented a bit, but it is hard to restrict the number of notifications thrown to just one, and the essence is also displayed in the label. So I am leaving that part for now. We can improve in the future.

nvazquez

Code LGTM

DaanHoogland added 2 commits February 17, 2025 18:50

ui fixes for vmware to kvm migration

e6503f5

reset host list when login fails

4be0fb0

DaanHoogland added this to the 4.19.2 milestone Feb 17, 2025

boring-cyborg bot added the component:UI label Feb 17, 2025

DaanHoogland requested review from kiranchavala, nvazquez and sureshanaparti February 17, 2025 17:58

change label from vcenter host to esxi host

4e9a442

DaanHoogland linked an issue Feb 17, 2025 that may be closed by this pull request

small UI regressions in convert Vmware to KVM VMs #10412

Closed

harikrishna-patnala approved these changes Feb 18, 2025

View reviewed changes

kiranchavala reviewed Feb 18, 2025

View reviewed changes

comments

0a4f163

sureshanaparti reviewed Feb 18, 2025

View reviewed changes

ui/src/views/tools/SelectVmwareVcenter.vue Show resolved Hide resolved

sureshanaparti reviewed Feb 18, 2025

View reviewed changes

ui/src/views/tools/SelectVmwareVcenter.vue Show resolved Hide resolved

DaanHoogland added 3 commits February 18, 2025 10:22

return needed on error

f0e9393

Revert "return needed on error"

371188b

This reverts commit f0e9393.

handle NPE when a host does not have any VMs

9b2a83d

boring-cyborg bot added the component:vmware label Feb 18, 2025

DaanHoogland added 2 commits February 18, 2025 15:16

only search with PW once the user presses enter

f7f81e0

only search with full set on explicit demand

2ef9a9f

kiranchavala approved these changes Feb 19, 2025

View reviewed changes

kiranchavala reviewed Feb 19, 2025

View reviewed changes

message

e9fc6f4

sureshanaparti approved these changes Feb 19, 2025

View reviewed changes

better messaging

23cc58d

nvazquez approved these changes Feb 19, 2025

View reviewed changes

DaanHoogland merged commit 66f8a35 into apache:4.19 Feb 19, 2025
25 of 26 checks passed

DaanHoogland deleted the ghi10412-migrateV2Kissues branch February 19, 2025 11:53

DaanHoogland mentioned this pull request Feb 20, 2025

small UI regressions in convert Vmware to KVM VMs #10412

Closed

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025

migrate Vmware to KVM ui issues (apache#10413)

4046e46

migrate Vmware to KVM ui issues #10413

migrate Vmware to KVM ui issues #10413

Uh oh!

Conversation

DaanHoogland commented Feb 17, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

DaanHoogland commented Feb 17, 2025

Uh oh!

codecov bot commented Feb 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

harikrishna-patnala commented Feb 18, 2025

Uh oh!

blueorangutan commented Feb 18, 2025

Uh oh!

blueorangutan commented Feb 18, 2025

Uh oh!

harikrishna-patnala left a comment

Choose a reason for hiding this comment

Uh oh!

kiranchavala left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Feb 18, 2025

Uh oh!

DaanHoogland commented Feb 18, 2025

Uh oh!

blueorangutan commented Feb 18, 2025

Uh oh!

blueorangutan commented Feb 18, 2025

Uh oh!

Uh oh!

Uh oh!

kiranchavala commented Feb 18, 2025

Uh oh!

blueorangutan commented Feb 18, 2025

Uh oh!

blueorangutan commented Feb 18, 2025

Uh oh!

blueorangutan commented Feb 18, 2025

Uh oh!

kiranchavala left a comment

Choose a reason for hiding this comment

Uh oh!

kiranchavala left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Feb 19, 2025

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Feb 19, 2025

Uh oh!

DaanHoogland commented Feb 19, 2025

Uh oh!

nvazquez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Feb 17, 2025 •

edited

Loading

kiranchavala left a comment •

edited

Loading