Skip to content

migrate Vmware to KVM ui issues #10413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 11 commits into from
Feb 19, 2025
Merged

migrate Vmware to KVM ui issues #10413

Changes from 3 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e6503f5
ui fixes for vmware to kvm migration
DaanHoogland Feb 17, 2025
4be0fb0
reset host list when login fails
DaanHoogland Feb 17, 2025
4e9a442
change label from vcenter host to esxi host
DaanHoogland Feb 17, 2025
0a4f163
comments
DaanHoogland Feb 18, 2025
f0e9393
return needed on error
DaanHoogland Feb 18, 2025
371188b
Revert "return needed on error"
DaanHoogland Feb 18, 2025
9b2a83d
handle NPE when a host does not have any VMs
DaanHoogland Feb 18, 2025
f7f81e0
only search with PW once the user presses enter
DaanHoogland Feb 18, 2025
2ef9a9f
only search with full set on explicit demand
DaanHoogland Feb 18, 2025
e9fc6f4
message
DaanHoogland Feb 19, 2025
23cc58d
better messaging
DaanHoogland Feb 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions ui/src/views/tools/SelectVmwareVcenter.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,16 +125,17 @@
</div>
<div
v-if="selectedExistingVcenterId || (vcenterSelectedOption === 'new')">
<a-form-item :label="$t('label.vcenter.host')" ref="host" name="host" v-if="hosts.length > 0">
<a-form-item :label="$t('label.esx.host')" ref="host" name="host" v-if="hosts.length > 0">
<a-select
v-model:value="form.host"
:loading="loading"
optionFilterProp="label"
:filterOption="(input, option) => {
return option.label.toLowerCase().indexOf(input.toLowerCase()) >= 0
}"
:placeholder="$t('label.vcenter.host')"
:placeholder="$t('label.esx.host')"
@change="onSelectExistingVmwareHost">
<a-select-option key="" label="">{{ }}</a-select-option>
<a-select-option v-for="opt in hosts" :key="opt.name">
{{ 'ESXi: ' + opt.name }}
</a-select-option>
Expand Down Expand Up @@ -283,7 +284,7 @@ export default {
this.loading = false
})
},
listZoneVmwareDcHosts () {
listZoneVmwareDcHosts (doNotify) {
this.loading = true
const params = {}
if (this.vcenterSelectedOption === 'new') {
Expand All @@ -299,18 +300,23 @@ export default {
this.hosts = response.listvmwaredchostsresponse.host
}
}).catch(error => {
this.$notifyError(error)
if (doNotify) {
this.$notifyError(error)
}
this.hosts = []
return false
}).finally(() => {
this.loading = false
return true
})
},
onSelectExistingVmwareDatacenter (value) {
this.selectedExistingVcenterId = value
this.listZoneVmwareDcHosts()
this.listZoneVmwareDcHosts(true)
},
onSelectExternalVmwareDatacenter (value) {
if (this.vcenterSelectedOption === 'new' && !(this.vcenter === '' || this.datacentername === '' || this.username === '' || this.password === '')) {
this.listZoneVmwareDcHosts()
this.listZoneVmwareDcHosts(false)
}
},
onSelectExistingVmwareHost (value) {
Expand Down
Loading