kvm: find cluster-wide pools only in Up state when investigate a host #10516

weizhouapache · 2025-03-06T09:39:06Z

Description

Currently when investigate a kvm host, it does not consider the state of cluster-wide pools, so the result is not correct.

There is no issue with zone-wide storage pools, as in the method findZoneWideStoragePoolsByHypervisor it has

sc.and(sc.entity().getStatus(), Op.EQ, Status.Up);

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2025-03-06T09:47:27Z

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 15.16%. Comparing base (b41acf2) to head (11402b6).
Report is 3 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...vm/src/main/java/com/cloud/ha/KVMInvestigator.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19   #10516      +/-   ##
============================================
- Coverage     15.17%   15.16%   -0.01%     
+ Complexity    11332    11329       -3     
============================================
  Files          5414     5414              
  Lines        474802   474802              
  Branches      57909    57909              
============================================
- Hits          72028    72010      -18     
- Misses       394718   394740      +22     
+ Partials       8056     8052       -4

Flag	Coverage Δ
uitests	`4.28% <ø> (ø)`
unittests	`15.89% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

weizhouapache · 2025-03-06T10:04:06Z

@blueorangutan package

blueorangutan · 2025-03-06T10:06:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-03-06T11:14:11Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12679

weizhouapache · 2025-03-06T11:17:33Z

@blueorangutan test

blueorangutan · 2025-03-06T11:18:04Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-03-06T12:00:47Z

[SF] Trillian Build Failed (tid-12596)

weizhouapache · 2025-03-06T14:36:20Z

@blueorangutan test

blueorangutan · 2025-03-06T14:38:05Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-03-07T04:31:08Z

[SF] Trillian test result (tid-12601)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 47468 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10516-t12601-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

DaanHoogland

clgtm

Pearl1594

clgtm

DaanHoogland · 2025-03-10T10:08:34Z

tested in lab env, when all storage pools are disabled immediately an error is returned that there is no pool available. When (any) one is enabled deployments work as expected.

Just foud out this doesn't test the change as expected. investigating more.

blueorangutan · 2025-03-10T11:56:38Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 12721

weizhouapache · 2025-03-10T12:09:42Z

@blueorangutan package

blueorangutan · 2025-03-10T12:12:03Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-03-10T13:35:24Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 12723

weizhouapache · 2025-03-10T13:42:28Z

@blueorangutan test

blueorangutan · 2025-03-10T13:44:03Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-03-10T13:47:18Z

[SF] Trillian Build Failed (tid-12637)

DaanHoogland · 2025-03-10T14:49:12Z

@Pearl1594 tested:

without the fix:

2025-03-10 12:35:50,893 DEBUG [c.c.h.KVMInvestigator] (AgentTaskPool-2:ctx-c22e955a) (logid:950000fd) HA: HOST is ineligible legacy state Disconnected for host 1
2025-03-10 12:35:50,898 DEBUG [c.c.h.HighAvailabilityManagerImpl] (AgentTaskPool-2:ctx-c22e955a) (logid:950000fd) KVMInvestigator was able to determine host 1 is in Disconnected

but than:

2025-03-10 12:35:50,898 DEBUG [c.c.s.StorageManagerImpl] (StatsCollector-5:ctx-5e1f25ef) (logid:dfdf31d0) Unable to send storage pool command to Pool[1|NetworkFilesystem] via 1
com.cloud.exception.OperationTimedoutException: Commands 823877256832090309 to Host 1 timed out after 3600
        at com.cloud.agent.manager.AgentAttache.send(AgentAttache.java:447)
        at com.cloud.agent.manager.AgentManagerImpl.send(AgentManagerImpl.java:465)
        at com.cloud.agent.manager.AgentManagerImpl.send(AgentManagerImpl.java:371)
        at com.cloud.storage.StorageManagerImpl.sendToPool(StorageManagerImpl.java:1678)

with this fix:

2025-03-10 14:41:31,888 WARN  [c.c.h.KVMInvestigator] (AgentTaskPool-1:ctx-45ac40c1) (logid:a75618f4) Agent investigation was requested on host Host {"id":1,"name":"ol8.localdomain","type":"Routing","uuid":"5f8
4e980-42e4-4f48-99ea-41e71c152f36"}, but host does not support investigation because it has no NFS storage. Skipping investigation.
2025-03-10 14:41:31,888 DEBUG [c.c.h.HighAvailabilityManagerImpl] (AgentTaskPool-1:ctx-45ac40c1) (logid:a75618f4) KVMInvestigator unable to determine the state of the host.  Moving on.

and then other investigators are called...

(cc @weizhouapache )

weizhouapache · 2025-03-10T15:56:16Z

@Pearl1594 tested:

without the fix:

2025-03-10 12:35:50,893 DEBUG [c.c.h.KVMInvestigator] (AgentTaskPool-2:ctx-c22e955a) (logid:950000fd) HA: HOST is ineligible legacy state Disconnected for host 1
2025-03-10 12:35:50,898 DEBUG [c.c.h.HighAvailabilityManagerImpl] (AgentTaskPool-2:ctx-c22e955a) (logid:950000fd) KVMInvestigator was able to determine host 1 is in Disconnected

but than:

2025-03-10 12:35:50,898 DEBUG [c.c.s.StorageManagerImpl] (StatsCollector-5:ctx-5e1f25ef) (logid:dfdf31d0) Unable to send storage pool command to Pool[1|NetworkFilesystem] via 1
com.cloud.exception.OperationTimedoutException: Commands 823877256832090309 to Host 1 timed out after 3600
        at com.cloud.agent.manager.AgentAttache.send(AgentAttache.java:447)
        at com.cloud.agent.manager.AgentManagerImpl.send(AgentManagerImpl.java:465)
        at com.cloud.agent.manager.AgentManagerImpl.send(AgentManagerImpl.java:371)
        at com.cloud.storage.StorageManagerImpl.sendToPool(StorageManagerImpl.java:1678)

with this fix:

2025-03-10 14:41:31,888 WARN  [c.c.h.KVMInvestigator] (AgentTaskPool-1:ctx-45ac40c1) (logid:a75618f4) Agent investigation was requested on host Host {"id":1,"name":"ol8.localdomain","type":"Routing","uuid":"5f8
4e980-42e4-4f48-99ea-41e71c152f36"}, but host does not support investigation because it has no NFS storage. Skipping investigation.
2025-03-10 14:41:31,888 DEBUG [c.c.h.HighAvailabilityManagerImpl] (AgentTaskPool-1:ctx-45ac40c1) (logid:a75618f4) KVMInvestigator unable to determine the state of the host.  Moving on.

and then other investigators are called...

(cc @weizhouapache )

thanks @DaanHoogland for the testing !

are you ok with the new behaviour ?

DaanHoogland · 2025-03-10T16:47:56Z

Yes @weizhouapache , the objective was to make sure other investigators continue as is proven, so yes. Whether other investigations should follow is another issue.

weizhouapache · 2025-03-10T18:48:37Z

Yes @weizhouapache , the objective was to make sure other investigators continue as is proven, so yes. Whether other investigations should follow is another issue.

Great, thanks @DaanHoogland
So it is fine with merging it

…apache#10516)

kvm: find cluster-wide pools only in Up state when investigate a host

11402b6

boring-cyborg bot added the component:kvm label Mar 6, 2025

weizhouapache added this to the 4.19.3 milestone Mar 6, 2025

weizhouapache marked this pull request as ready for review March 6, 2025 14:36

DaanHoogland approved these changes Mar 7, 2025

View reviewed changes

Pearl1594 approved these changes Mar 7, 2025

View reviewed changes

Pearl1594 merged commit 8ce34ad into apache:4.19 Mar 10, 2025
24 of 25 checks passed

Pearl1594 mentioned this pull request Mar 10, 2025

Revert "kvm: find cluster-wide pools only in Up state when investigate a host" #10535

Closed

DaanHoogland deleted the 4.19-kvm-investigator-pool-up-state branch March 10, 2025 14:52

Pearl1594 added this to ACS 4.20.1 Mar 17, 2025

Pearl1594 moved this to Done in ACS 4.20.1 Mar 17, 2025

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025

kvm: find cluster-wide pools only in Up state when investigate a host (…

4ed61c9

…apache#10516)

kvm: find cluster-wide pools only in Up state when investigate a host #10516

kvm: find cluster-wide pools only in Up state when investigate a host #10516

Uh oh!

Conversation

weizhouapache commented Mar 6, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Mar 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

weizhouapache commented Mar 6, 2025

Uh oh!

blueorangutan commented Mar 6, 2025

Uh oh!

blueorangutan commented Mar 6, 2025

Uh oh!

weizhouapache commented Mar 6, 2025

Uh oh!

blueorangutan commented Mar 6, 2025

Uh oh!

blueorangutan commented Mar 6, 2025

Uh oh!

weizhouapache commented Mar 6, 2025

Uh oh!

blueorangutan commented Mar 6, 2025

Uh oh!

blueorangutan commented Mar 7, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

Pearl1594 left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

blueorangutan commented Mar 10, 2025

Uh oh!

weizhouapache commented Mar 10, 2025

Uh oh!

blueorangutan commented Mar 10, 2025

Uh oh!

Uh oh!

blueorangutan commented Mar 10, 2025

Uh oh!

weizhouapache commented Mar 10, 2025

Uh oh!

blueorangutan commented Mar 10, 2025

Uh oh!

blueorangutan commented Mar 10, 2025

Uh oh!

DaanHoogland commented Mar 10, 2025

Uh oh!

weizhouapache commented Mar 10, 2025

Uh oh!

DaanHoogland commented Mar 10, 2025

Uh oh!

weizhouapache commented Mar 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Mar 6, 2025 •

edited

Loading

DaanHoogland commented Mar 10, 2025 •

edited

Loading