Skip to content

kvm: find cluster-wide pools only in Up state when investigate a host #10516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pearl1594 merged 1 commit into from
Mar 10, 2025
Merged

kvm: find cluster-wide pools only in Up state when investigate a host #10516

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion plugins/hypervisors/kvm/src/main/java/com/cloud/ha/KVMInvestigator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
import org.apache.log4j.Logger;

import javax.inject.Inject;
import java.util.Arrays;
import java.util.List;

public class KVMInvestigator extends AdapterBase implements Investigator {
Expand Down Expand Up @@ -83,7 +84,7 @@
return haManager.getHostStatus(agent);
}

List<StoragePoolVO> clusterPools = _storagePoolDao.listPoolsByCluster(agent.getClusterId());
List<StoragePoolVO> clusterPools = _storagePoolDao.findPoolsInClusters(Arrays.asList(agent.getClusterId()), null);

Check warning on line 87 in plugins/hypervisors/kvm/src/main/java/com/cloud/ha/KVMInvestigator.java

View check run for this annotation

Codecov / codecov/patch

plugins/hypervisors/kvm/src/main/java/com/cloud/ha/KVMInvestigator.java#L87 

Added line #L87 was not covered by tests
boolean storageSupportHA = storageSupportHa(clusterPools);
if (!storageSupportHA) {
List<StoragePoolVO> zonePools = _storagePoolDao.findZoneWideStoragePoolsByHypervisor(agent.getDataCenterId(), agent.getHypervisorType());
Expand Down