fix priority for volume copy operation #11109

shrikantjoshi-hpe · 2025-06-30T13:04:56Z

Description

This PR adds support to set the priority to high for volume copy operations using the Primera plugin.
This enhancement allows volume copy tasks handled by the Primera plugin to be prioritized as high, improving performance for critical operations. No changes to existing workflows or APIs; only the priority for copy operations is updated.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

N/A

How Has This Been Tested?

Manually tested the volume copy operation using the Primera plugin.
Verified that the copy operation is executed with high priority.

How did you try to break this feature and the system with this change?

Tested with multiple concurrent copy operations to ensure prioritization works as expected.
Confirmed no impact on unrelated features or plugins.

boring-cyborg · 2025-06-30T13:05:01Z

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
Be sure to read the CloudStack Coding Conventions.
Apache CloudStack is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: [email protected] (https://cloudstack.apache.org/mailing-lists.html)
Slack: https://apachecloudstack.slack.com/

tools/marvin/setup.py

codecov · 2025-07-01T09:38:52Z

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 16.57%. Comparing base (16c60c7) to head (59d5012).
Report is 18 commits behind head on main.

Files with missing lines	Patch %	Lines
...rage/datastore/adapter/primera/PrimeraAdapter.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #11109   +/-   ##
=========================================
  Coverage     16.57%   16.57%           
- Complexity    13968    13969    +1     
=========================================
  Files          5743     5743           
  Lines        510494   510495    +1     
  Branches      62075    62075           
=========================================
+ Hits          84617    84621    +4     
+ Misses       416415   416411    -4     
- Partials       9462     9463    +1

Flag	Coverage Δ
uitests	`3.90% <ø> (ø)`
unittests	`17.47% <0.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DaanHoogland

clgtm

shrikantjoshi-hpe · 2025-07-02T11:02:21Z

@DaanHoogland Is anything expected from us regarding the status:needs-testing label? I haven’t found any test coverage for the Primera plugin in the repository. Please advise.

DaanHoogland · 2025-07-02T17:16:55Z

@DaanHoogland Is anything expected from us regarding the status:needs-testing label? I haven’t found any test coverage for the Primera plugin in the repository. Please advise.

@shrikantjoshi-hpe , If there is no external hard- or software required, then we require an “external” reviewer to test it. So preferably not yourself. It will lower the bar if you add as extensive a test description as possible. If there is any proprietary stuff involved we “just” require regression tests performed.

In any case a second review and testing is “external” required.

shrikantjoshi-hpe · 2025-07-03T09:10:07Z

@DaanHoogland, Thank you for the details. With this change there is no proprietary information involved. Regarding testing, we performed multiple tests related to these code changes, mainly following the workflow of bringing up instances in CloudStack using templates and monitoring the volume copy task performance using Primera plugin. There is no change in workflow for end users; this update simply improves the performance of volume copy tasks on the array.

DaanHoogland · 2025-07-03T10:34:31Z

@shrikantjoshi-hpe , great. Try to find a second reviewer. Preferably someone still active that has changed the code that you touched. Couldn’t hurt to look at other storage vendors as well.
cc @slavkap , @rp- , @harikrishna-patnala this looks simple enough so shouldn’t require much thinking ;)

sureshanaparti

clgtm

Copilot

Pull Request Overview

This PR enhances the Primera plugin’s volume copy operation by always assigning it high priority.

Always sets the copy request’s priority to high (1)
No changes to workflows or APIs beyond priority level adjustment

Comments suppressed due to low confidence (2)

plugins/storage/volume/primera/src/main/java/org/apache/cloudstack/storage/datastore/adapter/primera/PrimeraAdapter.java:314

Add unit or integration tests to verify that the priority parameter is correctly set to high for copy operations so this behavior is validated automatically.

        parms.setPriority(1);

Copilot · 2025-07-04T12:28:34Z

...ra/src/main/java/org/apache/cloudstack/storage/datastore/adapter/primera/PrimeraAdapter.java


        parms.setDestVolume(targetVolumeInfo.getExternalName());
        parms.setOnline(false);
+        parms.setPriority(1);


Replace the magic number 1 with a named constant or enum (e.g., PRIORITY_HIGH) to clarify its meaning and improve maintainability.

sureshanaparti · 2025-07-04T12:42:56Z

@blueorangutan package

blueorangutan · 2025-07-04T12:44:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-04T17:00:00Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14040

shrikantjoshi-hpe · 2025-07-07T05:04:46Z

@DaanHoogland, code change has been reviewed by a second reviewer as well. Can you now consider it for merging?

slavkap

code LGTM

shrikantjoshi-hpe · 2025-07-09T04:44:03Z

@DaanHoogland, @sureshanaparti, @slavkap Is there anything further required from our side, or can this be considered for merging?

DaanHoogland · 2025-07-09T07:32:43Z

@blueorangutan test

blueorangutan · 2025-07-09T07:34:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

DaanHoogland · 2025-07-09T07:34:55Z

@DaanHoogland, @sureshanaparti, @slavkap Is there anything further required from our side, or can this be considered for merging?

@shrikantjoshi-hpe , at this moment there is nothing required/asked from you. We will run regression tests and give people opportunity to add their thoughts, but as this is such a small change I do not expect much more interaction on this PR.

blueorangutan · 2025-07-10T01:04:45Z

[SF] Trillian test result (tid-13732)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 59864 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11109-t13732-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_04_extract_Iso	`Failure`	1.13	test_iso.py
test_03_ping_in_ssvm_success	`Failure`	15.51	test_diagnostics.py
test_15_retrieve_ssvm_default_files	`Failure`	2.28	test_diagnostics.py
test_16_retrieve_ssvm_single_file	`Failure`	2.16	test_diagnostics.py
test_17_retrieve_cpvm_default_files	`Failure`	2.17	test_diagnostics.py
test_18_retrieve_cpvm_single_file	`Failure`	2.15	test_diagnostics.py

DaanHoogland · 2025-07-10T07:38:08Z

@blueorangutan test

blueorangutan · 2025-07-10T07:40:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-07-10T22:49:50Z

[SF] Trillian test result (tid-13748)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 51709 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11109-t13748-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

DaanHoogland · 2025-07-14T05:50:48Z

low impact and I see no-one testing this beyond regression, merging.

boring-cyborg · 2025-07-14T05:51:01Z

Awesome work, congrats on your first merged pull request!

fix priority for volume copy operation

04c03a0

boring-cyborg bot added component:marvin component:primary-storage component:storage Python Warning... Python code Ahead! labels Jun 30, 2025

DaanHoogland reviewed Jul 1, 2025

View reviewed changes

tools/marvin/setup.py Outdated Show resolved Hide resolved

Correct the version in setup.py

59d5012

DaanHoogland approved these changes Jul 1, 2025

View reviewed changes

DaanHoogland added the status:needs-testing label Jul 1, 2025

DaanHoogland added this to the 4.21.0 milestone Jul 1, 2025

sureshanaparti added this to Apache CloudStack 4.21.0 Jul 4, 2025

sureshanaparti moved this to In Progress in Apache CloudStack 4.21.0 Jul 4, 2025

sureshanaparti approved these changes Jul 4, 2025

View reviewed changes

sureshanaparti requested a review from Copilot July 4, 2025 12:27

Copilot AI reviewed Jul 4, 2025

View reviewed changes

slavkap approved these changes Jul 7, 2025

View reviewed changes

DaanHoogland added the 3rd-party:primera label Jul 14, 2025

DaanHoogland merged commit 4d46bec into apache:main Jul 14, 2025
25 of 26 checks passed

github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.21.0 Jul 14, 2025

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 16, 2025

fix priority for volume copy operation (apache#11109)

975b10d

fix priority for volume copy operation #11109

fix priority for volume copy operation #11109

Uh oh!

Conversation

shrikantjoshi-hpe commented Jun 30, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

boring-cyborg bot commented Jun 30, 2025

Uh oh!

Uh oh!

codecov bot commented Jul 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

shrikantjoshi-hpe commented Jul 2, 2025

Uh oh!

DaanHoogland commented Jul 2, 2025

Uh oh!

shrikantjoshi-hpe commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

DaanHoogland commented Jul 3, 2025

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Copilot AI Jul 4, 2025

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Jul 4, 2025

Uh oh!

blueorangutan commented Jul 4, 2025

Uh oh!

blueorangutan commented Jul 4, 2025

Uh oh!

shrikantjoshi-hpe commented Jul 7, 2025

Uh oh!

slavkap left a comment

Choose a reason for hiding this comment

Uh oh!

shrikantjoshi-hpe commented Jul 9, 2025

Uh oh!

DaanHoogland commented Jul 9, 2025

Uh oh!

blueorangutan commented Jul 9, 2025

Uh oh!

DaanHoogland commented Jul 9, 2025

Uh oh!

blueorangutan commented Jul 10, 2025

Uh oh!

DaanHoogland commented Jul 10, 2025

Uh oh!

blueorangutan commented Jul 10, 2025

Uh oh!

blueorangutan commented Jul 10, 2025

Uh oh!

DaanHoogland commented Jul 14, 2025

Uh oh!

Uh oh!

boring-cyborg bot commented Jul 14, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

codecov bot commented Jul 1, 2025 •

edited

Loading

shrikantjoshi-hpe commented Jul 3, 2025 •

edited

Loading