Skip to content

fix priority for volume copy operation #11109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DaanHoogland merged 2 commits into from
Jul 14, 2025
Merged

fix priority for volume copy operation #11109

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04c03a0
fix priority for volume copy operation
shrikantjoshi-hpe Jun 30, 2025
59d5012
Correct the version in setup.py
shrikantjoshi-hpe Jul 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...src/main/java/org/apache/cloudstack/storage/datastore/adapter/primera/PrimeraAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,7 @@

parms.setDestVolume(targetVolumeInfo.getExternalName());
parms.setOnline(false);
parms.setPriority(1);

Check warning on line 314 in plugins/storage/volume/primera/src/main/java/org/apache/cloudstack/storage/datastore/adapter/primera/PrimeraAdapter.java

View check run for this annotation

Codecov / codecov/patch

plugins/storage/volume/primera/src/main/java/org/apache/cloudstack/storage/datastore/adapter/primera/PrimeraAdapter.java#L314 

Added line #L314 was not covered by tests
Copy link

Copilot AI Jul 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Replace the magic number 1 with a named constant or enum (e.g., PRIORITY_HIGH) to clarify its meaning and improve maintainability.

Copilot uses AI. Check for mistakes.
request.setParameters(parms);

PrimeraTaskReference taskref = POST("/volumes/" + sourceVolumeInfo.getExternalName(), request, new TypeReference<PrimeraTaskReference>() {});
Expand Down
Loading