NAS BnR: Create Instance from Backup issues

[abh1sar]

Description

Fixes Issues

#11631 : Handle create instance from backup if the template was deleted (273920b)

#11746 : Create Instance from Backup on another Zone not showing Zone options for normal Users (35ea878)

#11747 : Reuse IP Address button not showing in Create Instance from Backup (77e9125)

Types of changes

• Breaking change (fix or feature that would cause existing functionality to change)
• New feature (non-breaking change which adds functionality)
• Bug fix (non-breaking change which fixes an issue)
• Enhancement (improves an existing feature and functionality)
• Cleanup (Code refactoring and cleanup, that may add test cases)
• Build/CI
• Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

• Major
• Minor

Bug Severity

• BLOCKER
• Critical
• Major
• Minor
• Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

[codecov]

Codecov Report

❌ Patch coverage is 17.85714% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 17.53%. Comparing base (9bcd988) to head (81d6631).

Files with missing lines	Patch %	Lines
...rg/apache/cloudstack/backup/BackupManagerImpl.java	41.66%	3 Missing and 4 partials ⚠️
server/src/main/java/com/cloud/api/ApiDBUtils.java	0.00%	5 Missing ⚠️
...loudstack/api/response/BackupOfferingResponse.java	0.00%	3 Missing ⚠️
...apache/cloudstack/api/response/BackupResponse.java	0.00%	3 Missing ⚠️
...e/cloudstack/backup/dao/BackupOfferingDaoImpl.java	0.00%	3 Missing ⚠️
...src/main/java/com/cloud/api/ApiResponseHelper.java	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11754      +/-   ##
============================================
- Coverage     17.53%   17.53%   -0.01%     
+ Complexity    15461    15459       -2     
============================================
  Files          5897     5897              
  Lines        527221   527230       +9     
  Branches      64378    64382       +4     
============================================
- Hits          92444    92434      -10     
- Misses       424382   424398      +16     
- Partials      10395    10398       +3     

Flag	Coverage Δ
uitests	3.60% <ø> (+<0.01%)	⬆️
unittests	18.59% <17.85%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[abh1sar]

@blueorangutan package

[blueorangutan]

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 15223

[abh1sar]

@blueorangutan package

[blueorangutan]

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15224

[sureshanaparti]

@blueorangutan package

[blueorangutan]

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

[blueorangutan]

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 15321