UI: Option to choose the isolation method when creating the public IP range #12000

sureshanaparti · 2025-11-06T08:39:22Z

Description

This PR enabled option in the UI to choose the isolation method (vlan, vxlan) when creating the public IP range.

Fixes #9920

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
Build/CI
Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Verified the isolation methods set in public IP range, from the UI.

IPv4:

IPv6:

How did you try to break this feature and the system with this change?

sureshanaparti · 2025-11-06T08:41:16Z

@blueorangutan package

blueorangutan · 2025-11-06T08:42:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2025-11-06T08:47:25Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 4.00%. Comparing base (243f566) to head (2951be1).
⚠️ Report is 1 commits behind head on 4.20.

❗ There is a different number of reports uploaded between BASE (243f566) and HEAD (2951be1). Click for more details.

HEAD has 1 upload less than BASE

Flag BASE (243f566) HEAD (2951be1)

unittests 1 0

Additional details and impacted files

@@              Coverage Diff              @@
##               4.20   #12000       +/-   ##
=============================================
- Coverage     16.18%    4.00%   -12.18%     
=============================================
  Files          5657      402     -5255     
  Lines        498473    32675   -465798     
  Branches      60501     5814    -54687     
=============================================
- Hits          80663     1309    -79354     
+ Misses       408830    31211   -377619     
+ Partials       8980      155     -8825

Flag	Coverage Δ
uitests	`4.00% <ø> (-0.01%)`	⬇️
unittests	`?`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sureshanaparti · 2025-11-06T08:50:32Z

@blueorangutan ui

blueorangutan · 2025-11-06T08:51:04Z

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

Copilot

Pull Request Overview

This pull request adds support for selecting an isolation method (VLAN or VXLAN) when creating public IP ranges in the UI, allowing users to specify the isolation method explicitly rather than relying on defaults. The change also fixes a duplicate command registration in the server code and improves null/empty string checks using Apache Commons.

Added UI form field for selecting isolation method with VLAN/VXLAN options
Implemented automatic VLAN formatting logic that prepends the isolation method prefix when a numeric VLAN ID is entered
Fixed duplicate ListNetworkIsolationMethodsCmd registration in server command list

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
ui/src/views/infra/network/IpRangesTabPublic.vue	Added isolation method dropdown and logic to format VLAN parameter with selected method prefix
ui/public/locales/en.json	Added tooltip text explaining the isolation method selection
server/src/main/java/com/cloud/server/ManagementServerImpl.java	Removed duplicate registration of ListNetworkIsolationMethodsCmd
api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/CreateVlanIpRangeCmd.java	Replaced null/empty check with StringUtils.isBlank()
api/src/main/java/org/apache/cloudstack/api/command/admin/network/CreateManagementNetworkIpRangeCmd.java	Replaced null/empty check with StringUtils.isBlank()

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ui/src/views/infra/network/IpRangesTabPublic.vue

blueorangutan · 2025-11-06T09:09:42Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12000 (QA-JID-791)

weizhouapache · 2025-11-06T09:21:15Z

@sureshanaparti
does it work for ipv6 too ?
can we use 'vlan' as default isolated method ?

blueorangutan · 2025-11-06T10:07:44Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15649

sureshanaparti · 2025-11-06T10:10:41Z

@sureshanaparti does it work for ipv6 too ? can we use 'vlan' as default isolated method ?

will check/udpate for ipv6 as well. correct - 'vlan' is used as default isolated method if not set.

… range

sureshanaparti · 2025-12-02T12:35:06Z

@sureshanaparti does it work for ipv6 too ? can we use 'vlan' as default isolated method ?

will check/udpate for ipv6 as well. correct - 'vlan' is used as default isolated method if not set.

@weizhouapache it works with ipv6 as well.

sureshanaparti · 2025-12-02T12:35:15Z

@blueorangutan ui

blueorangutan · 2025-12-02T12:36:04Z

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2025-12-02T12:55:58Z

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/12000 (QA-JID-816)

DaanHoogland · 2025-12-03T06:50:41Z

.../java/org/apache/cloudstack/api/command/admin/network/CreateManagementNetworkIpRangeCmd.java

 import com.cloud.exception.ResourceAllocationException;
 import com.cloud.exception.ResourceUnavailableException;
 import com.cloud.user.Account;
+import org.apache.commons.lang3.StringUtils;


Suggested change

import org.apache.commons.lang3.StringUtils;

import com.cloud.utils.StringUtils;

DaanHoogland · 2025-12-03T06:51:06Z

api/src/main/java/org/apache/cloudstack/api/command/admin/vlan/CreateVlanIpRangeCmd.java

 import com.cloud.exception.ResourceAllocationException;
 import com.cloud.exception.ResourceUnavailableException;
 import com.cloud.user.Account;
+import org.apache.commons.lang3.StringUtils;


Suggested change

import org.apache.commons.lang3.StringUtils;

import com.cloud.utils.StringUtils;

DaanHoogland · 2025-12-03T06:54:29Z

server/src/main/java/com/cloud/server/ManagementServerImpl.java

        cmdList.add(StartInternalLBVMCmd.class);
        cmdList.add(ListInternalLBVMsCmd.class);
        cmdList.add(ListNetworkIsolationMethodsCmd.class);
-        cmdList.add(ListNetworkIsolationMethodsCmd.class);


should this be deleted?

yes, it's duplicate

boring-cyborg bot added component:api component:management-server component:UI labels Nov 6, 2025

sureshanaparti linked an issue Nov 6, 2025 that may be closed by this pull request

VXLAN isolation method does not pass the correct broadcast domain type when creating the vlan public IP range #9920

Open

sureshanaparti requested review from Pearl1594, Copilot and weizhouapache November 6, 2025 08:51

sureshanaparti added this to the 4.20.3 milestone Nov 6, 2025

Copilot AI reviewed Nov 6, 2025

View reviewed changes

ui/src/views/infra/network/IpRangesTabPublic.vue Show resolved Hide resolved

ui/src/views/infra/network/IpRangesTabPublic.vue Outdated Show resolved Hide resolved

sureshanaparti added 2 commits December 2, 2025 17:41

UI: Option to choose the isolation method when creating the public IP…

856738b

… range

review

664a025

sureshanaparti force-pushed the ui-isolation-method-for-public-ip-range branch from 3d06ea2 to 664a025 Compare December 2, 2025 12:11

DaanHoogland requested changes Dec 3, 2025

View reviewed changes

import update

2951be1

	import org.apache.commons.lang3.StringUtils;
	import com.cloud.utils.StringUtils;

UI: Option to choose the isolation method when creating the public IP range #12000

Are you sure you want to change the base?

UI: Option to choose the isolation method when creating the public IP range #12000

Uh oh!

Conversation

sureshanaparti commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

sureshanaparti commented Nov 6, 2025

Uh oh!

blueorangutan commented Nov 6, 2025

Uh oh!

codecov bot commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sureshanaparti commented Nov 6, 2025

Uh oh!

blueorangutan commented Nov 6, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

blueorangutan commented Nov 6, 2025

Uh oh!

weizhouapache commented Nov 6, 2025

Uh oh!

blueorangutan commented Nov 6, 2025

Uh oh!

sureshanaparti commented Nov 6, 2025

Uh oh!

sureshanaparti commented Dec 2, 2025

Uh oh!

sureshanaparti commented Dec 2, 2025

Uh oh!

blueorangutan commented Dec 2, 2025

Uh oh!

blueorangutan commented Dec 2, 2025

Uh oh!

DaanHoogland Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

sureshanaparti Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

DaanHoogland Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

sureshanaparti Dec 3, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sureshanaparti commented Nov 6, 2025 •

edited

Loading

codecov bot commented Nov 6, 2025 •

edited

Loading