Skip to content
Open
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
import com.cloud.exception.ResourceAllocationException;
import com.cloud.exception.ResourceUnavailableException;
import com.cloud.user.Account;
import org.apache.commons.lang3.StringUtils;

@APICommand(name = "createManagementNetworkIpRange",
description = "Creates a Management network IP range.",
Expand Down Expand Up @@ -118,7 +119,7 @@ public Boolean isForSystemVms() {
}

public String getVlan() {
if (vlan == null || vlan.isEmpty()) {
if (StringUtils.isBlank(vlan)) {
vlan = "untagged";
}
return vlan;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
import com.cloud.exception.ResourceAllocationException;
import com.cloud.exception.ResourceUnavailableException;
import com.cloud.user.Account;
import org.apache.commons.lang3.StringUtils;

import java.util.Objects;

Expand Down Expand Up @@ -162,7 +163,7 @@ public boolean isForNsx() {
}

public String getVlan() {
if ((vlan == null || vlan.isEmpty()) && !isForNsx()) {
if (StringUtils.isBlank(vlan) && !isForNsx()) {
vlan = "untagged";
}
return vlan;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3917,7 +3917,6 @@ public List<Class<?>> getCommands() {
cmdList.add(StartInternalLBVMCmd.class);
cmdList.add(ListInternalLBVMsCmd.class);
cmdList.add(ListNetworkIsolationMethodsCmd.class);
cmdList.add(ListNetworkIsolationMethodsCmd.class);
cmdList.add(CreateNetworkACLListCmd.class);
cmdList.add(DeleteNetworkACLListCmd.class);
cmdList.add(ListNetworkACLListsCmd.class);
Expand Down
1 change: 1 addition & 0 deletions ui/public/locales/en.json
Original file line number Diff line number Diff line change
Expand Up @@ -497,6 +497,7 @@
"label.checksum": "Checksum",
"label.choose.resource.icon": "Choose icon",
"label.choose.saml.identity": "Choose SAML identity provider",
"label.choose.isolation.method.public.ip.range": "Choose the proper isolation method for the public IP range in accordance with the zone. Valid options currently 'vlan' or 'vxlan', defaults to 'vlan'.",
"label.cidr": "CIDR",
"label.cidrsize": "CIDR size",
"label.cidr.destination.network": "Destination Network CIDR",
Expand Down
26 changes: 25 additions & 1 deletion ui/src/views/infra/network/IpRangesTabPublic.vue
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,20 @@
<a-select-option v-for="pod in pods" :key="pod.id" :value="pod.id" :label="pod.name">{{ pod.name }}</a-select-option>
</a-select>
</a-form-item>
<a-form-item name="isolationmethod" ref="isolationmethod" class="form__item" v-if="!basicGuestNetwork">
<tooltip-label :title="$t('label.isolation.method')" :tooltip="$t('label.choose.isolation.method.public.ip.range')" class="tooltip-label-wrapper"/>
<a-select
v-model:value="form.isolationmethod"
showSearch
optionFilterProp="label"
:filterOption="(input, option) => {
return option.label.toLowerCase().indexOf(input.toLowerCase()) >= 0
}" >
<a-select-option value="">{{ }}</a-select-option>
<a-select-option value="vlan"> VLAN </a-select-option>
<a-select-option value="vxlan"> VXLAN </a-select-option>
</a-select>
</a-form-item>
<a-form-item name="vlan" ref="vlan" :label="$t('label.vlan')" class="form__item" v-if="!basicGuestNetwork">
<a-input v-model:value="form.vlan" />
</a-form-item>
Expand Down Expand Up @@ -452,7 +466,8 @@ export default {
initAddIpRangeForm () {
this.formRef = ref()
this.form = reactive({
iptype: ''
iptype: '',
isolationmethod: ''
})
this.rules = reactive({
podid: [{ required: true, message: this.$t('label.required') }],
Expand Down Expand Up @@ -624,6 +639,15 @@ export default {
if (!this.basicGuestNetwork) {
params.zoneId = this.resource.zoneid
params.vlan = values.vlan
const vlanInput = (values.vlan || '').toString().trim()
if (vlanInput) {
const vlanInputLower = vlanInput.toLowerCase()
const startsWithPrefix = vlanInputLower.startsWith('vlan') || vlanInputLower.startsWith('vxlan')
const isNumeric = /^[0-9]+$/.test(vlanInput)
if (!startsWithPrefix && isNumeric && values.isolationmethod) {
params.vlan = `${values.isolationmethod}://${vlanInput}`
}
}
params.forsystemvms = values.forsystemvms
params.account = values.forsystemvms ? null : values.account
params.domainid = values.forsystemvms ? null : values.domain
Expand Down
Loading