UI: make a newly added Network the default one #9708
Conversation
…tance's Network tab
|
@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9708 +/- ##
==========================================
Coverage 15.81% 15.81%
- Complexity 12553 12554 +1
==========================================
Files 5629 5629
Lines 492015 492028 +13
Branches 61440 62367 +927
==========================================
+ Hits 77813 77823 +10
- Misses 405879 405885 +6
+ Partials 8323 8320 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
UI build: ✔️ |
|
@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
DaanHoogland
changed the title
kiranchavala
left a comment
kiranchavala
left a comment
There was a problem hiding this comment.
LGTM, Tested the Qa build,
|
@blueorangutan test |
|
@kiranchavala a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
@JoaoJandre @DaanHoogland some PRs targeting 4.20.1 are merged on main - should they go to 4.20 branch? |
|
@rohityadavcloud Considering that they were not targeting 4.19 (a maintenance branch), I assumed the authors wanted their changes to be made on the main branch directly. I'll fix the milestone. If the authors want their changes to be on the 4.20 branch, I volunteer to backport the PRs (#9930, #9708, #9956). |
|
@JoaoJandre This is a small change but very useful. It would be great if we can put this to 4.20.1 as well. |
* UI: Checkbox to make a newly added Network the default one in the Instance's Network tab * Fixed an issue that was causing exit from network tab after add-network
* UI: Checkbox to make a newly added Network the default one in the Instance's Network tab * Fixed an issue that was causing exit from network tab after add-network Co-authored-by: Abhisar Sinha <[email protected]>
* UI: Checkbox to make a newly added Network the default one in the Instance's Network tab * Fixed an issue that was causing exit from network tab after add-network
…10022) * UI: Checkbox to make a newly added Network the default one in the Instance's Network tab * Fixed an issue that was causing exit from network tab after add-network Co-authored-by: Abhisar Sinha <[email protected]>
8 participants
Checkbox to make a newly added Network the default one in the Instance's Network tab
Description
This PR adds a checkbox into the Add Network dialogue to make the newly added network the default one in Instance's Network Tab. This will save users from performing an extra step to make the network the default one.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?