Skip to content

Conversation

@LayonRibeiro
Copy link
Contributor

Description

This PR intends to enable the visualization of the amount of CPU/memory allocated in custom constrained compute offerings, which is currently not possible, thus improving the user experience.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Before

before

After

after

How Has This Been Tested?

The CPU/memory ranges appeared in the offerings table under Compute Offerings.

@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.80%. Comparing base (f7b7339) to head (e8e4779).
Report is 506 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #9930      +/-   ##
============================================
- Coverage     15.80%   15.80%   -0.01%     
  Complexity    12586    12586              
============================================
  Files          5627     5627              
  Lines        492294   492341      +47     
  Branches      62198    59693    -2505     
============================================
+ Hits          77824    77828       +4     
- Misses       405946   405990      +44     
+ Partials       8524     8523       -1     
Flag Coverage Δ
uitests 4.04% <ø> (-0.01%) ⬇️
unittests 16.63% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9930 (QA-JID-479)

@DaanHoogland
Copy link
Contributor

@blueorangutan ui

@blueorangutan
Copy link

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9930 (QA-JID-480)

Copy link
Member

@winterhazel winterhazel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified in qa

Before

image

After

image


Related, but not required for this PR: we could also include the CPU/memory range in the compute offering's info card

image

@DaanHoogland DaanHoogland added this to the 4.20.1 milestone Nov 28, 2024
@JoaoJandre JoaoJandre merged commit 528fca2 into apache:main Nov 28, 2024
26 checks passed
@rohityadavcloud
Copy link
Member

@JoaoJandre @DaanHoogland some PRs targeting 4.20.1 are merged on main - should they go to 4.20 branch?

@JoaoJandre
Copy link
Contributor

@rohityadavcloud Considering that they were not targeting 4.19 (a maintenance branch), I assumed the authors wanted their changes to be made on the main branch directly. I'll fix the milestone. If the authors want their changes to be on the 4.20 branch, I volunteer to backport the PRs (#9930, #9708, #9956).

@JoaoJandre JoaoJandre modified the milestones: 4.20.1, 4.21.0 Nov 29, 2024
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Dec 12, 2024
…ache#9930)

* Added-cpu-core-and-memory-range-fot-type-offers-CustomConstrained

* Update ui/src/components/view/ListView.vue

Co-authored-by: Fabricio Duarte <[email protected]>

* Update ui/src/components/view/ListView.vue

Co-authored-by: Fabricio Duarte <[email protected]>

---------

Co-authored-by: layon.oliveira <[email protected]>
Co-authored-by: Fabricio Duarte <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

7 participants