-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Added-cpu-core-and-memory-range-fot-type-offers-CustomConstrained #9930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added-cpu-core-and-memory-range-fot-type-offers-CustomConstrained #9930
Conversation
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9930 +/- ##
============================================
- Coverage 15.80% 15.80% -0.01%
Complexity 12586 12586
============================================
Files 5627 5627
Lines 492294 492341 +47
Branches 62198 59693 -2505
============================================
+ Hits 77824 77828 +4
- Misses 405946 405990 +44
+ Partials 8524 8523 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
UI build: ✔️ |
Co-authored-by: Fabricio Duarte <[email protected]>
Co-authored-by: Fabricio Duarte <[email protected]>
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
winterhazel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
|
@JoaoJandre @DaanHoogland some PRs targeting 4.20.1 are merged on main - should they go to 4.20 branch? |
|
@rohityadavcloud Considering that they were not targeting 4.19 (a maintenance branch), I assumed the authors wanted their changes to be made on the main branch directly. I'll fix the milestone. If the authors want their changes to be on the 4.20 branch, I volunteer to backport the PRs (#9930, #9708, #9956). |
…ache#9930) * Added-cpu-core-and-memory-range-fot-type-offers-CustomConstrained * Update ui/src/components/view/ListView.vue Co-authored-by: Fabricio Duarte <[email protected]> * Update ui/src/components/view/ListView.vue Co-authored-by: Fabricio Duarte <[email protected]> --------- Co-authored-by: layon.oliveira <[email protected]> Co-authored-by: Fabricio Duarte <[email protected]>



Description
This PR intends to enable the visualization of the amount of CPU/memory allocated in custom constrained compute offerings, which is currently not possible, thus improving the user experience.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
The CPU/memory ranges appeared in the offerings table under Compute Offerings.