Skip to content

Conversation

@kumo01GitHub
Copy link
Contributor

@kumo01GitHub kumo01GitHub commented Jul 17, 2025

Platforms affected

n/a

Motivation and Context

node < 20 are already EOL.

Description

  • Upgrade node to 20.5.0
  • Bump node modules:
    • cordova-common
    • cordova-lib
    • nopt
    • semver
    • systeminformation
    • @cordova/eslint-config
    • jasmine
    • nyc
    • rewire
  • Update packages by npm update

NOTE:

  • configstore could not be updated because it switched commonjs to esm from next version 6.0.0.
  • execa ould not be updated because it switched commonjs to esm from next version 6.0.0.
  • nyc should be replaced with c8 but separate from this PR.

Testing

  • npm t
  • npm run lint

Checklist

  • I've run the tests to see all new and existing tests pass
  • I added automated test coverage as appropriate for this change
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)
  • I've updated the documentation if necessary

@erisu erisu changed the title chore:bump node chore!: bump node requirement & npm dependencies Jul 18, 2025
Copy link
Member

@erisu erisu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested by:

  • Rebuilt package-lock.json to confirm changes
  • npm t
    • npm run lint
  • Verified the bumped npm dependencies were not using type module (ESM)

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.53%. Comparing base (618404f) to head (0ac585c).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #666   +/-   ##
=======================================
  Coverage   65.53%   65.53%           
=======================================
  Files           3        3           
  Lines         235      235           
=======================================
  Hits          154      154           
  Misses         81       81           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@erisu erisu merged commit e15951b into apache:master Jul 19, 2025
11 checks passed
@kumo01GitHub kumo01GitHub deleted the chore/bump-node branch July 19, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants