-
Notifications
You must be signed in to change notification settings - Fork 345
chore!: bump node requirement & npm dependencies #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Tested by:
- Rebuilt
package-lock.jsonto confirm changes npm tnpm run lint
- Verified the bumped npm dependencies were not using type module (ESM)
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #666 +/- ##
=======================================
Coverage 65.53% 65.53%
=======================================
Files 3 3
Lines 235 235
=======================================
Hits 154 154
Misses 81 81 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Platforms affected
n/a
Motivation and Context
node < 20 are already EOL.
Description
npm updateNOTE:
configstorecould not be updated because it switched commonjs to esm from next version 6.0.0.execaould not be updated because it switched commonjs to esm from next version 6.0.0.nycshould be replaced withc8but separate from this PR.Testing
Checklist
(platform)if this change only applies to one platform (e.g.(android))