update rust edition to 2024 #1290
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
thanks for splitting it up @Huy1Ng One note, as we're tracking datafusion 49 which has MSRV 1.85.1 we cant rally merge this for now https://github.com/apache/datafusion/blob/273d37a5968571900bfe9efa1ee89f97914da118/Cargo.toml#L78 |
Huy1Ng
deleted the
improve-github-actions/update-rust-edition-to-2024
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1271
Rationale for this change
Update Rust edition. This is a part of PR #1289 as later version seem to improve CI time.
What changes are included in this PR?
cargo fix --editioncargo fmtcargo clippy --fixSo most changes are automatic.
Are there any user-facing changes?
Not sure