Skip to content

Conversation

@comphead
Copy link
Contributor

Which issue does this PR close?

Part of #2382

Closes #.

Rationale for this change

Currently the code doesn't give a clue what group expression is not supported, adding clarity in this PR

What changes are included in this PR?

How are these changes tested?

@codecov-commenter
Copy link

codecov-commenter commented Sep 12, 2025

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.57%. Comparing base (f09f8af) to head (2731b49).
⚠️ Report is 496 commits behind head on main.

Files with missing lines Patch % Lines
.../scala/org/apache/comet/serde/QueryPlanSerde.scala 57.14% 0 Missing and 3 partials ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #2383       +/-   ##
=============================================
- Coverage     56.12%   43.57%   -12.56%     
- Complexity      976     1083      +107     
=============================================
  Files           119      147       +28     
  Lines         11743    13418     +1675     
  Branches       2251     2349       +98     
=============================================
- Hits           6591     5847      -744     
- Misses         4012     6568     +2556     
+ Partials       1140     1003      -137     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@comphead comphead merged commit d9c2b3a into apache:main Sep 12, 2025
94 checks passed
coderfender pushed a commit to coderfender/datafusion-comet that referenced this pull request Dec 13, 2025
…2383)

* chore: Output `BaseAggregateExec` accurate unsupported names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants