Skip to content

chore: Output BaseAggregateExec accurate unsupported names #2383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
comphead merged 2 commits into from
Sep 12, 2025
Merged

chore: Output BaseAggregateExec accurate unsupported names #2383

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c908c7a
chore: Output `BaseAggregateExec` accurate unsupported names
comphead Sep 11, 2025
2731b49
chore: Output `BaseAggregateExec` accurate unsupported names
comphead Sep 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 11 additions & 3 deletions spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1440,12 +1440,20 @@ object QueryPlanSerde extends Logging with CometExprShim {
return None
}

val groupingExprs = groupingExpressions.map(exprToProto(_, child.output))
if (groupingExprs.exists(_.isEmpty)) {
withInfo(op, "Not all grouping expressions are supported")
val groupingExprsWithInput =
groupingExpressions.map(expr => expr.name -> exprToProto(expr, child.output))

val emptyExprs = groupingExprsWithInput.collect {
case (expr, proto) if proto.isEmpty => expr
}

if (emptyExprs.nonEmpty) {
withInfo(op, s"Unsupported group expressions: ${emptyExprs.mkString(", ")}")
return None
}

val groupingExprs = groupingExprsWithInput.map(_._2)

// In some of the cases, the aggregateExpressions could be empty.
// For example, if the aggregate functions only have group by or if the aggregate
// functions only have distinct aggregate functions:
Expand Down
Loading