[infra] Fail Clippy on rust build warnings #1029
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
interestingly, |
|
CI should fail. Now we just need to fix the warnings 😄 |
kevinjqliu
force-pushed
the
kevinjqliu/clippy-fails-on-warning
branch
from
c8942b4 to
ad37552
Compare
|
ah I was going to rebase after #1030 is merged, but this works too. Thanks! |
kosiew
pushed a commit
to kosiew/datafusion-python
that referenced
this pull request
Mar 5, 2025
* pyo3 update required changes to deprecated interfaces * Substrait feature clippy updates * PyTuple was called twice * add -D warnings option --------- Co-authored-by: Tim Saucer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1028
Rationale for this change
CI should fail if rust warnings are generated
What changes are included in this PR?
Add
-D warningstocargo clippycommandsAre there any user-facing changes?
Nope