Skip to content

Conversation

@timsaucer
Copy link
Member

Which issue does this PR close?

None, but it supports PR #1029

Rationale for this change

pyo3 update recently introduced a lot of warnings about deprecated APIs. This PR addresses those warnings.

What changes are included in this PR?

Changed to new interfaces and associated error returns.

Are there any user-facing changes?

None

Copy link
Contributor

@kevinjqliu kevinjqliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I verified locally by running

cargo clippy --all-targets --all-features -- -D clippy::all -D warnings -A clippy::redundant_closure

@kevinjqliu
Copy link
Contributor

I added this PR to #1029 to check CI and everything is green!

@timsaucer timsaucer marked this pull request as ready for review February 20, 2025 01:49
@timsaucer
Copy link
Member Author

Closing in favor of #1029

@timsaucer timsaucer closed this Feb 20, 2025
@timsaucer timsaucer deleted the bugfix/clippy-warnings branch February 20, 2025 01:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants