Unpin aws sdk dependencies in datafusion-cli#14361
Conversation
datafusion-cli/Cargo.toml
Outdated
| aws-sdk-sts = "=1.51.0" | ||
| # end pin aws-sdk crates | ||
| aws-credential-types = "1.2.0" | ||
| aws-config = "1.5.15" |
There was a problem hiding this comment.
Thats probably another question but do we need to follow a practice of setting the exact patch version?
https://semver.org
We probably can provide a minor version and let rustc take the latest patch. However it is not very expected when the patch requires MSRV change though.... WDYT folks if we set all deps without the specifc patch version and see how it is going.
There was a problem hiding this comment.
We probably can provide a minor version and let rustc take the latest patch. However it is not very expected when the patch requires MSRV change though.... WDYT folks if we set all deps without the specifc patch version and see how it is going.
Sounds good to me -- I will do so
I think the practical implication of 1.5.15 is that it will also allow anything higher, such as 1.6, 1.5.16
Since everything in datafusion-cli is controlled by Cargo.lock the versions won't change without a change to that file anyways.
That being said there is no reason to have this patch version as you say so I will remove it
|
Thanks again @comphead |
2 participants
Which issue does this PR close?
Now that we have updated MSRV, we can unpin some of the dependencies
Rationale for this change
Keep up with dependencies
What changes are included in this PR?
Unpin aws* dependieces
Are these changes tested?
By CI
Are there any user-facing changes?