Skip to content

Unpin aws sdk dependencies in datafusion-cli #14361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 3 commits into from
Jan 30, 2025
Merged

Unpin aws sdk dependencies in datafusion-cli #14361

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1fbebde
Unpin aws sdk dependencies
alamb Jan 29, 2025
62474ec
Merge remote-tracking branch 'apache/main' into alamb/unpin_deps
alamb Jan 29, 2025
58f7441
Merge remote-tracking branch 'apache/main' into alamb/unpin_deps
alamb Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 10 additions & 19 deletions datafusion-cli/Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 5 additions & 10 deletions datafusion-cli/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,16 +31,11 @@ readme = "README.md"
[dependencies]
arrow = { version = "54.0.0" }
async-trait = "0.1.73"
## 1.5.13 requires a hiher MSRV 1.81 so lock until DataFusion MSRV catches up
aws-config = "=1.5.10"
## 1.53.0 requires a higher MSRV 1.81 so lock until DataFusion MSRV catches up
aws-sdk-sso = "=1.50.0"
## 1.54.0 requires a higher MSRV 1.81 so lock until DataFusion MSRV catches up
aws-sdk-ssooidc = "=1.57.1"
## 1.54.1 requires a higher MSRV 1.81 so lock until DataFusion MSRV catches up
aws-sdk-sts = "=1.51.0"
# end pin aws-sdk crates
aws-credential-types = "1.2.0"
aws-config = "1.5.15"
Copy link
Contributor

@comphead comphead Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thats probably another question but do we need to follow a practice of setting the exact patch version?
https://semver.org

We probably can provide a minor version and let rustc take the latest patch. However it is not very expected when the patch requires MSRV change though.... WDYT folks if we set all deps without the specifc patch version and see how it is going.

Copy link
Contributor Author

@alamb alamb Jan 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably can provide a minor version and let rustc take the latest patch. However it is not very expected when the patch requires MSRV change though.... WDYT folks if we set all deps without the specifc patch version and see how it is going.

Sounds good to me -- I will do so

I think the practical implication of 1.5.15 is that it will also allow anything higher, such as 1.6, 1.5.16

Since everything in datafusion-cli is controlled by Cargo.lock the versions won't change without a change to that file anyways.

That being said there is no reason to have this patch version as you say so I will remove it

aws-credential-types = "1.2.1"
aws-sdk-sso = "1.56.0"
aws-sdk-ssooidc = "1.57.0"
aws-sdk-sts = "1.57.0"
clap = { version = "4.5.27", features = ["derive", "cargo"] }
datafusion = { path = "../datafusion/core", version = "44.0.0", features = [
"avro",
Expand Down
Loading