add a ci job for typo checking #17339
Conversation
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
Signed-off-by: Ruihang Xia <[email protected]>
github-actions
bot
added
development-process
datafusion/core/tests/physical_optimizer/filter_pushdown/mod.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jeffrey Vo <[email protected]>
| hte = "hte" | ||
| numer = "numer" | ||
| abd = "abd" | ||
| aroun = "aroun" |
There was a problem hiding this comment.
Looks like "around" with last letter chopped off. Can we remove this?
| Ue = "Ue" | ||
| Iy = "Iy" | ||
| hte = "hte" | ||
| numer = "numer" |
There was a problem hiding this comment.
Looks like "number" with 'b' lost. Can we remove this?
| carefull = "carefull" | ||
| precentage = "precentage" |
There was a problem hiding this comment.
Can we remove these? These are clearly misspelled words that should be flagged.
If they show up in some test data we don't want / can't modify, maybe we can exclude-list that data set instead,
| - uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 | ||
| with: | ||
| persist-credentials: false | ||
| - uses: crate-ci/typos@v1 |
There was a problem hiding this comment.
Per https://infra.apache.org/github-actions-policy.html this should use commit hash.
I am not sure https://github.com/apache/infrastructure-actions/blob/main/approved_patterns.yml is normative. In any case, i read it as saying we can use the action. Not saying that we can safely use the action without pinning to a hash.
|
This new check just got a stupid typo i made in a hurry. Thank you for catching me! |
3 participants
Which issue does this PR close?
Rationale for this change
Add a CI job to check typo (we got four new typos in these two weeks XD)
What changes are included in this PR?
A new ci job
Are these changes tested?
Are there any user-facing changes?