Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .github/workflows/rust.yml
Original file line number Diff line number Diff line change
Expand Up @@ -781,3 +781,11 @@ jobs:
- name: Check datafusion-proto
working-directory: datafusion/proto
run: cargo msrv --output-format json --log-target stdout verify
typos:
name: Spell Check with Typos
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683
with:
persist-credentials: false
- uses: crate-ci/typos@v1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per https://infra.apache.org/github-actions-policy.html this should use commit hash.
I am not sure https://github.com/apache/infrastructure-actions/blob/main/approved_patterns.yml is normative. In any case, i read it as saying we can use the action. Not saying that we can safely use the action without pinning to a hash.

Original file line number Diff line number Diff line change
Expand Up @@ -1095,7 +1095,7 @@ async fn test_hashjoin_dynamic_filter_pushdown_partitioned() {
// Top-level CoalesceBatchesExec
let cb =
Arc::new(CoalesceBatchesExec::new(hash_join, 8192)) as Arc<dyn ExecutionPlan>;
// Top-level CoalesceParititionsExec
// Top-level CoalescePartitionsExec
let cp = Arc::new(CoalescePartitionsExec::new(cb)) as Arc<dyn ExecutionPlan>;
// Add a sort for determistic output
let plan = Arc::new(SortExec::new(
Expand Down
2 changes: 1 addition & 1 deletion datafusion/physical-plan/src/joins/join_filter.rs
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ pub struct JoinFilter {
}

/// For display in `EXPLAIN` plans, only expression with column names is needed,
/// it output expresion like `(col1 + col2) = 0`
/// it output expression like `(col1 + col2) = 0`
impl Display for JoinFilter {
fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result {
self.expression.fmt_sql(f)
Expand Down
4 changes: 2 additions & 2 deletions datafusion/physical-plan/src/joins/nested_loop_join.rs
Original file line number Diff line number Diff line change
Expand Up @@ -827,7 +827,7 @@ impl Stream for NestedLoopJoinStream {
// side batch, before start joining.
NLJState::BufferingLeft => {
debug!("[NLJState] Entering: {:?}", self.state);
// inside `collect_left_input` (the rountine to buffer build
// inside `collect_left_input` (the routine to buffer build
// -side batches), related metrics except build time will be
// updated.
// stop on drop
Expand Down Expand Up @@ -1583,7 +1583,7 @@ fn apply_filter_to_row_join_batch(
/// 30
/// 40
///
/// # After applying it, only index 1 and 3 elemnt in probe_side_batch will be
/// # After applying it, only index 1 and 3 elements in probe_side_batch will be
/// # kept
/// probe_side_filter:
/// false
Expand Down
46 changes: 46 additions & 0 deletions typos.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,46 @@
[default.extend-words]
# random words from unit tests
Pn = "Pn"
fo = "fo"
nd = "nd"
Nd = "Nd"
ba = "ba"
ECT = "ECT"
Ue = "Ue"
Iy = "Iy"
hte = "hte"
numer = "numer"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like "number" with 'b' lost. Can we remove this?

abd = "abd"
aroun = "aroun"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like "around" with last letter chopped off. Can we remove this?

abov = "abov"
Ois = "Ois"
alo = "alo"

# abbreviations, common words, etc.
typ = "typ"
datas = "datas"
YOUY = "YOUY"
lits = "lits"

# exposed to public API
Serializeable = "Serializeable"

# from test cases like TPC-* or ClickBench
carefull = "carefull"
precentage = "precentage"
Comment on lines +29 to +30
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove these? These are clearly misspelled words that should be flagged.
If they show up in some test data we don't want / can't modify, maybe we can exclude-list that data set instead,

flate = "flate"
hom = "hom"
alph = "alph"
wih = "wih"
Ded = "Ded"

[files]
extend-exclude = [
"*.slt",
"*.slt.part",
"*.svg",
"*.sql",
"dev/changelog/**",
"benchmarks/**",
"*.csv"
]