-
Notifications
You must be signed in to change notification settings - Fork 1.7k
add a ci job for typo checking #17339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| [default.extend-words] | ||
| # random words from unit tests | ||
| Pn = "Pn" | ||
| fo = "fo" | ||
| nd = "nd" | ||
| Nd = "Nd" | ||
| ba = "ba" | ||
| ECT = "ECT" | ||
| Ue = "Ue" | ||
| Iy = "Iy" | ||
| hte = "hte" | ||
| numer = "numer" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like "number" with 'b' lost. Can we remove this? |
||
| abd = "abd" | ||
| aroun = "aroun" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Looks like "around" with last letter chopped off. Can we remove this? |
||
| abov = "abov" | ||
| Ois = "Ois" | ||
| alo = "alo" | ||
|
|
||
| # abbreviations, common words, etc. | ||
| typ = "typ" | ||
| datas = "datas" | ||
| YOUY = "YOUY" | ||
| lits = "lits" | ||
|
|
||
| # exposed to public API | ||
| Serializeable = "Serializeable" | ||
|
|
||
| # from test cases like TPC-* or ClickBench | ||
| carefull = "carefull" | ||
| precentage = "precentage" | ||
|
Comment on lines
+29
to
+30
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can we remove these? These are clearly misspelled words that should be flagged. |
||
| flate = "flate" | ||
| hom = "hom" | ||
| alph = "alph" | ||
| wih = "wih" | ||
| Ded = "Ded" | ||
|
|
||
| [files] | ||
| extend-exclude = [ | ||
| "*.slt", | ||
| "*.slt.part", | ||
| "*.svg", | ||
| "*.sql", | ||
| "dev/changelog/**", | ||
| "benchmarks/**", | ||
| "*.csv" | ||
| ] | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per https://infra.apache.org/github-actions-policy.html this should use commit hash.
I am not sure https://github.com/apache/infrastructure-actions/blob/main/approved_patterns.yml is normative. In any case, i read it as saying we can use the action. Not saying that we can safely use the action without pinning to a hash.