Refactor: Split test_window_partial_constant_and_set_monotonicity from enforce_sorting
#17903
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m enforce_sorting
alamb
commented
Oct 3, 2025
| @@ -1652,94 +1647,6 @@ async fn test_not_replaced_with_partial_sort_for_bounded_input() -> Result<()> { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| /// Runs the sort enforcement optimizer and asserts the plan | |||
There was a problem hiding this comment.
I just moved 1200 lines of test code into a different module. I did not change any of the test logic
|
@berkaysynnada I wonder if you have time to review this PR (I think it should be fairly simple as it just moves code around) |
|
I refactored it in #17900 (but didn't move to the new file to speed up the review) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
coretests toinsta#15791Rationale for this change
I found that the enforce_sorting tests need many updates (b/c the plan output
changed) while working on the arrow 57 upgrade, and I am trying to make the
enforce_sorting tests easier to maintain.
At the moment the module is huge (almost 4000 lines) it is totally unobvious (to me) that there are two macros called
"assert_optimized_plan" in enforce_sorting.rs and there is one giant test test function
with many cases in it.
I will refactor it in a follow on PR; The first step is to split the test
into its own module.
What changes are included in this PR?
Move
test_window_partial_constant_and_set_monotonicityinto its own moduleAre these changes tested?
Yes, by CI
Are there any user-facing changes?
no this is a development process nly