Fix concat_elements_utf8view capacity initialization.
#18003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
concat_elements_utf8viewpanics with large buffer on 64bit machines #17857 (Seeconcat_elements_utf8viewpanics with large buffer on 64bit machines #17857 (comment))Rationale for this change
The capacity calculation replaced with
left.len()(assumingleft.len()andright.len()are the same). As thewith_capacityrefers to the length of the views (or strings), not to the length of the bytesAre these changes tested?
The function is already covered by tests.
Are there any user-facing changes?
No