Skip to content

Fix concat_elements_utf8view capacity initialization. #18003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix concat_elements_utf8view capacity initialization. #18003

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3c06a28
Fix concat_elements_utf8view capacity initialization.
samueleresca Oct 9, 2025
55fe71f
Merge branch 'main' into fix-capacity-concat-utf8-view
samueleresca Oct 9, 2025
d4df45f
Merge branch 'main' into fix-capacity-concat-utf8-view
samueleresca Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions datafusion/physical-expr/src/expressions/binary/kernels.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,12 +137,14 @@ pub fn concat_elements_utf8view(
left: &StringViewArray,
right: &StringViewArray,
) -> std::result::Result<StringViewArray, ArrowError> {
let capacity = left
.data_buffers()
.iter()
.zip(right.data_buffers().iter())
.map(|(b1, b2)| b1.len() + b2.len())
.sum();
if left.len() != right.len() {
return Err(ArrowError::ComputeError(format!(
"Arrays must have the same length: {} != {}",
left.len(),
right.len()
)));
}
let capacity = left.len();
let mut result = StringViewBuilder::with_capacity(capacity);

// Avoid reallocations by writing to a reused buffer (note we
Expand Down