Downgrade aws-smithy-runtime, update rust_decimal, ignore RUSTSEC-2026-0001 to get clean CI
#19657
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
changed the title
rust_decimal to avoid rustsec errors
Contributor
Author
|
Looks like there is something wrong with rkyv as well |
Contributor
Author
|
I am going to be lazy and wait to see if someone upstream hits the same issue and hopefully we get a fix out |
Contributor
|
fwiw the rust_decimal team seems to be waiting on a backport of the fix for rkyv - paupino/rust-decimal#767 (comment) |
Contributor
|
Looks like rkyv released a backport Though the advisory db still requires |
…ion into alamb/downgrade_aws-smithy
Contributor
Author
|
Looks like there is progress being made on the upstream issue In the interim, I'll add a ignore to the file to get CI passing cleanly again and I have an AI trying to remove the rust_decimal dependency |
github-actions
bot
added
the
development-process
alamb
changed the title
rust_decimal to avoid rustsec errorsrust_decimal, ignore RUSTSEC-2026-0001 to get clean CI
Jefffrey
approved these changes
Jan 6, 2026
Contributor
Author
|
Merging this to get the CI clean |
Contributor
Author
|
Here is my proposal to remove the dependnecy (and the --ignore) |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 7, 2026
…001` (#19666) ## Which issue does this PR close? - Part of #19656 ## Rationale for this change rust_decimal is a one person crate and is released somewhat infrequently * https://github.com/paupino/rust-decimal * https://crates.io/crates/rust_decimal It also uses a non trivial number of dependencies, including https://crates.io/crates/rkyv, some sort of zero copy deserialization framework that was recently subject to a RUSTSEC security advisory, see #19656 / #19657 Since `rust_decimal` is only used for sqllogictests to parse the results from postgres, we can pretty easily remove the dependency on `rust_decimal` and inline the very small amount functionality we need for sqllogictests This will both decrease the build time and our dependency trail. ## What changes are included in this PR? Removes the `rust_decimal` dependency from DataFusion and inlines the smallest required subset of decimal functionality we need for sqllogictests (which turns out to be pretty small) ## Are these changes tested? Yes by CI ## Are there any user-facing changes? No, this is all internal testing infrastructure
alamb
added a commit
to alamb/datafusion
that referenced
this pull request
Jan 7, 2026
…001` (apache#19666) - Part of apache#19656 rust_decimal is a one person crate and is released somewhat infrequently * https://github.com/paupino/rust-decimal * https://crates.io/crates/rust_decimal It also uses a non trivial number of dependencies, including https://crates.io/crates/rkyv, some sort of zero copy deserialization framework that was recently subject to a RUSTSEC security advisory, see apache#19656 / apache#19657 Since `rust_decimal` is only used for sqllogictests to parse the results from postgres, we can pretty easily remove the dependency on `rust_decimal` and inline the very small amount functionality we need for sqllogictests This will both decrease the build time and our dependency trail. Removes the `rust_decimal` dependency from DataFusion and inlines the smallest required subset of decimal functionality we need for sqllogictests (which turns out to be pretty small) Yes by CI No, this is all internal testing infrastructure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
CI is failing I think because aws-smithy-runtime was yanked
What changes are included in this PR?
ran
cargo updatefor this crate and then checked in the results:Are these changes tested?
I tested locally
Are there any user-facing changes?
No this is a developmnt process only