[Fix-17984][UI] Release workflow definition list loading lock on request failure#17989
Open
asadjan4611 wants to merge 6 commits intoapache:devfrom
Open
[Fix-17984][UI] Release workflow definition list loading lock on request failure#17989asadjan4611 wants to merge 6 commits intoapache:devfrom
asadjan4611 wants to merge 6 commits intoapache:devfrom
Conversation
SbloodyS
reviewed
Feb 25, 2026
| }) | ||
| }) | ||
| .catch((err: Error) => { | ||
| window.$message.error(err?.message || 'Request failed') |
Member
There was a problem hiding this comment.
It's better to use i18n to show message.
Author
There was a problem hiding this comment.
Thanks for the suggestion. I’ve updated the error message to use i18n instead of a hardcoded string, and added corresponding locale entries in both en_US and zh_CN.
This reverts commit 051b9c1.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
This pull request fixes a UI bug in the workflow definition list page where the table remained in loading state after a failed list request, preventing further retries (search, pagination, refresh) until page reload.
close #17984
Brief change log
loadingRefis reset in afinallyblock for both success and failure paths.Verify this pull request
This change added no new test files and can be verified as follows:
Pull Request Notice
Pull Request Notice
If your pull request contains incompatible change, you should also add it to
docs/docs/en/guide/upgrade/incompatible.mdfixes 17984