-
Notifications
You must be signed in to change notification settings - Fork 5k
[Fix-17984][UI] Release workflow definition list loading lock on request failure #17989
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
asadjan4611
wants to merge
6
commits into
apache:dev
Choose a base branch
from
asadjan4611:Fix-17984
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+18
−5
Open
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
bbbfd65
[Fix-17984][UI] Release workflow definition list loading lock on requ…
asadjan4611 607133d
[Fix-17984][UI] Format workflow definition loading fix for lint check
asadjan4611 d46aef1
[Fix-17984][UI] Use i18n message for workflow definition request failure
asadjan4611 c323146
Merge branch 'dev' into Fix-17984
SbloodyS 051b9c1
[Doc-17948] Replace unstable Kubernetes zh-cn link in task docs
asadjan4611 670e637
Revert "[Doc-17948] Replace unstable Kubernetes zh-cn link in task docs"
asadjan4611 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better to use i18n to show message.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion. I’ve updated the error message to use i18n instead of a hardcoded string, and added corresponding locale entries in both
en_USandzh_CN.