-
Notifications
You must be signed in to change notification settings - Fork 3.7k
[Fix](Compaction) Fix cumulative compaction pick rowsets to trim by max score after filtering #59268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix](Compaction) Fix cumulative compaction pick rowsets to trim by max score after filtering #59268
Conversation
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
07bd493 to
8ed5c9d
Compare
|
run buildall |
TPC-H: Total hot run time: 34725 ms |
TPC-DS: Total hot run time: 179418 ms |
ClickBench: Total hot run time: 27.09 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run buildall |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
|
run performance |
TPC-H: Total hot run time: 34772 ms |
TPC-DS: Total hot run time: 179918 ms |
ClickBench: Total hot run time: 27.39 s |
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
…ax score after filtering (#59268)
…ax score after filtering (#59268)
…to trim by max score after filtering #59268 (#59475) Cherry-picked from #59268 Co-authored-by: Jimmy <[email protected]>
…ax score after filtering (apache#59268) (apache#6471)
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
• Background
The current cumulative compaction pick logic can fail to select any rowsets in a corner case (large head rowsets + high min/max config + many empty rowsets), causing
compaction to stall.
Key Changes
Behavior Changes
Testing
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)