[fix](filecache) reset_range dose not update shadow queue causing large cache size #59314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ge cache size shadown queue is copying the actual LRU queue and provide lockless acess. but the copying loses updating size when actual LRU queue is reseting range (when load data, we first allocate 1MB block for the data and reset the size to the real size when finalizing). This commit does the following to fix this problem: 1. update the corresponding shadow queue element when resetting 2. calibrate size during initial loading into memory process Signed-off-by: zhengyu <[email protected]>
Signed-off-by: zhengyu <[email protected]>
freemandealer
requested review from
dataroaring and
gavinchou
as code owners
Contributor
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 36532 ms |
TPC-DS: Total hot run time: 180044 ms |
ClickBench: Total hot run time: 27.25 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run p0 |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run p0 |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run p0 |
gavinchou
previously approved these changes
Dec 26, 2025
koarz
approved these changes
Dec 26, 2025
Contributor
Author
|
run buildall |
Contributor
|
PR approved by anyone and no changes requested. |
TPC-H: Total hot run time: 34120 ms |
TPC-DS: Total hot run time: 174397 ms |
ClickBench: Total hot run time: 26.73 s |
Contributor
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
dataroaring
reviewed
Dec 30, 2025
| iter->size = new_size; | ||
| queue.cache_size -= old_size; | ||
| queue.cache_size += new_size; | ||
| queue.resize(*cell->queue_iterator, new_size, cache_lock); |
Contributor
There was a problem hiding this comment.
It is easily to map queue.resize to std::queue.resize.
Contributor
Author
There was a problem hiding this comment.
what does that mean? need to change to another name?
Contributor
Author
|
run buildall |
TPC-H: Total hot run time: 31813 ms |
TPC-DS: Total hot run time: 172970 ms |
ClickBench: Total hot run time: 26.64 s |
BE UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
Contributor
Author
|
run p0 |
Contributor
Author
|
run vault_p0 |
Contributor
BE Regression && UT Coverage ReportIncrement line coverage Increment coverage report
|
github-actions
bot
added
the
approved
Contributor
|
PR approved by at least one committer and no changes requested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
shadown queue is copying the actual LRU queue and provide lockless acess. but the copying loses updating size when actual LRU queue is reseting range (when load data, we first allocate 1MB block for the data and reset the size to the real size when finalizing).
This commit does the following to fix this problem:
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)