Skip to content

[Chore](bitmap) change BitmapValue CHECK to throw exception #59464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
BiteTheDDDDt merged 1 commit into from
Dec 30, 2025
Merged

[Chore](bitmap) change BitmapValue CHECK to throw exception #59464

BiteTheDDDDt merged 1 commit into from
Dec 30, 2025

Conversation

@BiteTheDDDDt
Copy link
Contributor

@BiteTheDDDDt BiteTheDDDDt commented Dec 30, 2025 •
edited
Loading

What problem does this PR solve?

This pull request refactors error handling in the BitmapValue class to improve robustness and provide clearer error messages. Instead of using CHECK macros, it now throws exceptions with detailed information when inconsistencies are detected in the bitmap value's set count.

Error handling improvements:

  • Replaced CHECK and CHECK_EQ macros with explicit exception throwing (Exception(ErrorCode::INTERNAL_ERROR, ...)) when the set count exceeds the threshold or does not match the expected size, including detailed error messages with the problematic values.

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 30, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@BiteTheDDDDt
Copy link
Contributor Author

BiteTheDDDDt commented Dec 30, 2025

run buildall

mrhhsg
mrhhsg approved these changes Dec 30, 2025
View reviewed changes
Copy link
Member

@mrhhsg mrhhsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Dec 30, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2025

PR approved by at least one committer and no changes requested.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2025

PR approved by anyone and no changes requested.

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 30, 2025

BE UT Coverage Report

Increment line coverage 22.22% (2/9) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 53.42% (18963/35500)
Line Coverage 39.29% (175909/447724)
Region Coverage 33.85% (136106/402132)
Branch Coverage 34.78% (58768/168979)

@hello-stephen
Copy link
Contributor

hello-stephen commented Dec 30, 2025

BE Regression && UT Coverage Report

Increment line coverage 22.22% (2/9) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 72.26% (25084/34713)
Line Coverage 58.95% (263444/446859)
Region Coverage 53.85% (218933/406562)
Branch Coverage 55.44% (94078/169700)

@BiteTheDDDDt BiteTheDDDDt merged commit bf2669e into apache:master Dec 30, 2025
30 of 32 checks passed
github-actions bot pushed a commit that referenced this pull request Dec 30, 2025
@BiteTheDDDDt
[Chore](bitmap) change BitmapValue CHECK to throw exception (#59464)
244bcf6 
This pull request refactors error handling in the `BitmapValue` class to
improve robustness and provide clearer error messages. Instead of using
`CHECK` macros, it now throws exceptions with detailed information when
inconsistencies are detected in the bitmap value's set count.

**Error handling improvements:**

* Replaced `CHECK` and `CHECK_EQ` macros with explicit exception
throwing (`Exception(ErrorCode::INTERNAL_ERROR, ...)`) when the set
count exceeds the threshold or does not match the expected size,
including detailed error messages with the problematic values.
@github-actions github-actions bot mentioned this pull request Dec 30, 2025
Merged
yiguolei pushed a commit that referenced this pull request Dec 31, 2025
@github-actions @BiteTheDDDDt
branch-4.0: [Chore](bitmap) change BitmapValue CHECK to throw exception
91d7bcb 
#59464 (#59491)

Cherry-picked from #59464

Co-authored-by: Pxl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrhhsg mrhhsg mrhhsg approved these changes

@yiguolei yiguolei yiguolei approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. dev/3.1.x dev/3.1.x-conflict dev/4.0.3-merged reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BiteTheDDDDt @hello-stephen @mrhhsg @yiguolei