You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem Summary:
The existing cache consistency check assumes estimated_file_count >= db_block_count, but in real-world data lake workloads with many small files, this assumption breaks and produces negative discrepancy ratios. Negative ratios do not meaningfully represent divergence and can cause the system to skip filesystem reloads incorrectly.
This PR changes the calculation to use the absolute difference, ensuring the metric reflects discrepancy magnitude regardless of direction and making cache consistency decisions more robust.
Release note
None
Check List (For Author)
Test
Regression test
Unit Test
Manual test (add detailed scripts or steps below)
No need to test or manual test. Explain why:
This is a refactor/code format and no logic has been changed.
xuchenhao
changed the title
[fix] (filecache) use absolute difference for cache consistency check.
[fix] (filecache) use absolute difference for cache consistency check
Jan 5, 2026
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: close #59504
Related PR: #xxx
Problem Summary:
The existing cache consistency check assumes
estimated_file_count>=db_block_count, but in real-world data lake workloads with many small files, this assumption breaks and produces negative discrepancy ratios. Negative ratios do not meaningfully represent divergence and can cause the system to skip filesystem reloads incorrectly.This PR changes the calculation to use the absolute difference, ensuring the metric reflects discrepancy magnitude regardless of direction and making cache consistency decisions more robust.
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)