Skip to content

[fix] (filecache) use absolute difference for cache consistency check #59559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xuchenhao wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[fix] (filecache) use absolute difference for cache consistency check #59559

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e679152
Use absolute difference for cache consistency check.
xuchenhao Jan 5, 2026
2fedb11
Format the code.
xuchenhao Jan 5, 2026
5137933
Merge branch 'master' into abs-difference-ratio
xuchenhao Jan 6, 2026
6c748c1
Merge branch 'master' into abs-difference-ratio
xuchenhao Jan 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions be/src/io/cache/fs_file_cache_storage.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -877,9 +877,9 @@ void FSFileCacheStorage::load_cache_info_into_memory(BlockFileCache* _mgr) const

// If the difference is more than threshold, load from filesystem as well
if (estimated_file_count > 100) {
double difference_ratio =
(static_cast<double>(estimated_file_count) - static_cast<double>(db_block_count)) /
static_cast<double>(estimated_file_count);
double absolute_difference = std::abs(static_cast<double>(estimated_file_count) -
static_cast<double>(db_block_count));
double difference_ratio = absolute_difference / static_cast<double>(estimated_file_count);

if (difference_ratio > config::file_cache_meta_store_vs_file_system_diff_num_threshold) {
LOG(WARNING) << "Significant difference between DB blocks (" << db_block_count
Expand Down