[Backport] MSQ: Fix composing channels losing partitionless frames.#18267
Merged
capistrant merged 1 commit intoapache:34.0.0from Jul 16, 2025
Merged
[Backport] MSQ: Fix composing channels losing partitionless frames.#18267capistrant merged 1 commit intoapache:34.0.0from
capistrant merged 1 commit intoapache:34.0.0from
Conversation
* MSQ: Fix composing channels losing partitionless frames. The main change is that single-partition ComposingWritableFrameChannels (i.e. those created by `ChannelOutputFactory#openChannel`) now associate all incoming frames with that partition. Previously, frames might have come in with partition set to `NO_PARTITION`, which would cause them to get "lost" by the composing channel. Fixes a bug introduced in apache#18144 when composed intermediate stage-internal channels started being used for the output of hash partitioning. Prior to apache#18144, they were only used for internal channels of the SuperSorter. This bug could cause frames to go missing during sortMerge joins. This patch also adds an embedded test for various durable storage scenarios, including sortMerge join tests that would have caught the original bug. Finally, this patch adjusts the way that Calcites escapes string literals, to use the actual characters more often when possible. This helps format the test SQLs generated by the embedded test more nicely. * dependency analyze. --------- Co-authored-by: Karan Kumar <karankumar1100@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #18220 to 34.0.0.