refactor: remove unnecessary @SuppressWarnings and simplify logic #684
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fy cache activation logic
GOODBOY008
force-pushed
the
polish-code
branch
from
486f60c to
8a972c7
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes unnecessary @SuppressWarnings("serial") annotations from inner classes that extend Format and simplifies conditional logic in SimpleReadCacheSelector. The changes include making CellFormatResultWrapper static and refactoring nested if-else statements for better readability.
- Removed
@SuppressWarnings("serial")annotations from three static inner classes - Changed
CellFormatResultWrapperfrom a non-static to static inner class - Refactored if-else logic in
SimpleReadCacheSelector.readCache()to reduce nesting
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| DataFormatter.java | Removed serialization suppression warnings and made CellFormatResultWrapper static |
| SimpleReadCacheSelector.java | Simplified conditional logic by inverting condition and flattening nested structure |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fesod/src/main/java/org/apache/fesod/sheet/cache/selector/SimpleReadCacheSelector.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.