Skip to content

refactor: remove unnecessary @SuppressWarnings and simplify logic #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
delei merged 3 commits into from
Nov 14, 2025
+4 −11
Merged

refactor: remove unnecessary @SuppressWarnings and simplify logic #684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8a972c7
refactor: remove unnecessary @SuppressWarnings annotations and simpli…
GOODBOY008 Nov 12, 2025
09d5749
Merge branch 'main' into polish-code
delei Nov 12, 2025
f09b9be
Apply suggestion from @Copilot
GOODBOY008 Nov 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions fesod/src/main/java/org/apache/fesod/sheet/cache/selector/SimpleReadCacheSelector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,13 +114,9 @@ public ReadCache readCache(PackagePart sharedStringsTablePackagePart) {

// In order to be compatible with the code
// If the user set up `maxCacheActivateSize`, then continue using it
if (maxCacheActivateSize != null) {
return new Ehcache(maxCacheActivateSize, maxCacheActivateBatchCount);
} else {
if (maxCacheActivateBatchCount == null) {
maxCacheActivateBatchCount = DEFAULT_MAX_EHCACHE_ACTIVATE_BATCH_COUNT;
}
return new Ehcache(maxCacheActivateSize, maxCacheActivateBatchCount);
if (maxCacheActivateBatchCount == null) {
maxCacheActivateBatchCount = DEFAULT_MAX_EHCACHE_ACTIVATE_BATCH_COUNT;
}
return new Ehcache(maxCacheActivateSize, maxCacheActivateBatchCount);
}
}
5 changes: 1 addition & 4 deletions fesod/src/main/java/org/apache/fesod/sheet/metadata/format/DataFormatter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -747,7 +747,6 @@ public static void setExcelStyleRoundingMode(DecimalFormat format, RoundingMode
/**
* Format class for Excel's SSN format. This class mimics Excel's built-in SSN formatting.
*/
@SuppressWarnings("serial")
private static final class SSNFormat extends Format {
private static final DecimalFormat df = createIntegerOnlyFormat("000000000");

Expand Down Expand Up @@ -777,7 +776,6 @@ public Object parseObject(String source, ParsePosition pos) {
/**
* Format class for Excel Zip + 4 format. This class mimics Excel's built-in formatting for Zip + 4.
*/
@SuppressWarnings("serial")
private static final class ZipPlusFourFormat extends Format {
private static final DecimalFormat df = createIntegerOnlyFormat("000000000");

Expand Down Expand Up @@ -807,7 +805,6 @@ public Object parseObject(String source, ParsePosition pos) {
/**
* Format class for Excel phone number format. This class mimics Excel's built-in phone number formatting.
*/
@SuppressWarnings("serial")
private static final class PhoneFormat extends Format {
private static final DecimalFormat df = createIntegerOnlyFormat("##########");

Expand Down Expand Up @@ -857,7 +854,7 @@ public Object parseObject(String source, ParsePosition pos) {
* non-cachable wrapper around a
* {@link CellFormatResult}
*/
private final class CellFormatResultWrapper extends Format {
private static final class CellFormatResultWrapper extends Format {
private final CellFormatResult result;

private CellFormatResultWrapper(CellFormatResult result) {
Expand Down