Skip to content

Conversation

@delei
Copy link
Member

@delei delei commented Nov 16, 2025

Purpose of the pull request

Releated #651

What's changed?

  • Modify the sidebar menu
  • Rename FastExcel to FesodSheet
  • Optimize the descriptions of Excel terms

Checklist

  • I have read the Contributor Guide.
  • I have written the necessary doc or comment.
  • I have added the necessary unit tests and all cases have passed.

@psxjoy psxjoy self-requested a review November 17, 2025 12:16
Copy link
Member

@psxjoy psxjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@psxjoy psxjoy self-requested a review November 17, 2025 12:36
Copy link
Member

@psxjoy psxjoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging

@psxjoy psxjoy merged commit d8625e0 into apache:main Nov 17, 2025
10 checks passed
@delei delei deleted the fesod-website-preview branch November 17, 2025 12:37
@ongdisheng
Copy link
Contributor

Hi @delei, great work on the rename! I noticed a couple of small issues in the website that were missed.

  1. Fesod.read in website/docs/introduce.md:57 where the read example still uses Fesod.read instead of FesodSheet.read. The Chinese version already has this correct, but the English version was missed.
image
  1. A few spots in the homepage translations still use Excel terminology instead of spreadsheet in website/i18n/en/code.json such as "reading and writing Excel files" and "large-scale Excel data".
image

Just wanted to flag these in case they were overlooked. If you'd like, I'm happy to submit a follow-up PR to fix them!

@delei
Copy link
Member Author

delei commented Nov 18, 2025

Welcome, Please feel free to submit a PR to fix it at any time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants